movefasta/nixpkgs
1
0
Fork 0
mirror of https://github.com/NixOS/nixpkgs.git synced 2025-06-09 19:13:26 +03:00
Code Issues Projects Releases Packages Wiki Activity
nixpkgs/pkgs/applications/networking/browsers/firefox/common.nix

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

717 lines
22 KiB
Nix
Raw Normal View History

firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
{
pname,
version,
buildMozillaMach: allow distinct source and package versions Signed-off-by: Christoph Heiss <christoph@c8h4.io>
2023-10-10 17:35:11 +02:00
packageVersion ? version,
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
meta,
updateScript ? null,
binaryName ? "firefox",
application ? "browser",
firefox, thunderbird: enable wrapped derivations for darwin It also aligns application names for wrapped and unwrapped flavors of the same derivations; and uses unique application names for each flavor, so it's now possible to install multiple versions on the same Darwin machine. One visible change now is that `About Firefox` window now shows: `Firefox for NixOS` instead of `Mozilla Firefox for NixOS` ...in the `distribution` field. I think it's fine and doesn't infringe on any trademarks because this field is not required to mention Mozilla at all, as per: https://wiki.mozilla.org/Distribution_INI_File While at it, also changed the branding for Darwin builds to list: `Firefox for Nix on MacOS` instead of `Firefox for NixOS` The telemetry and distribution ids (`nixos`) are left intact. Note: it's still not possible to install both source-based and -bin Darwin derivations in the same profile. It would require renaming applicationNames for these two different types to use unique names (e.g. `Firefox (Official)` or `Firefox (Binary)`, which doesn't seem optimal. Closes: #378433 Closes: #366581 Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
2025-01-29 20:35:46 -05:00
applicationName ? "Firefox",
buildMozillaMach: add branding option to change the path where the branding is located
2023-03-23 17:47:51 +01:00
branding ? null,
buildMozillaMach: support disabling extension signing enforcement Previously, derivations specified the environment variable themselves, which did not actually disable signing enforcement.
2023-07-20 19:13:51 -04:00
requireSigning ? true,
buildMozillaMach: support addon sideloading
2023-11-14 09:40:05 -05:00
allowAddonSideload ? false,
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
src,
unpackPhase ? null,
firefox: rename patches arg to extraPatches This is for consistency with other extra arguments that can be handed to firefox common.nix. Also pull the patch phase of the derivation closer together and use the same list concat style as elsewhere.
2022-03-21 03:44:02 +01:00
extraPatches ? [ ],
extraPostPatch ? "",
extraNativeBuildInputs ? [ ],
extraConfigureFlags ? [ ],
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
extraBuildInputs ? [ ],
firefox: rename patches arg to extraPatches This is for consistency with other extra arguments that can be handed to firefox common.nix. Also pull the patch phase of the derivation closer together and use the same list concat style as elsewhere.
2022-03-21 03:44:02 +01:00
extraMakeFlags ? [ ],
extraPassthru ? { },
buildMozillaMach: change tests to an attrset
2024-10-19 14:12:19 +02:00
tests ? { },
firefox: rename patches arg to extraPatches This is for consistency with other extra arguments that can be handed to firefox common.nix. Also pull the patch phase of the derivation closer together and use the same list concat style as elsewhere.
2022-03-21 03:44:02 +01:00
}:
buildMozillaMach: allow overriding requireSigning/allowAddonSideload
2023-11-25 02:30:25 -05:00
let
# Rename the variables to prevent infinite recursion
requireSigningDefault = requireSigning;
allowAddonSideloadDefault = allowAddonSideload;
buildMozillaMach: re-enable elf-hack with LTO/LLD, disable with musl (#365185) The elfhack was completely revamped and is now implemented with the "relrhack", which is compatible with LLD: https://glandium.org/blog/?p=4297 Exposes a new option elfhackSupport and sets reasonable default based on the properties of the new relrhack. Change-Id: I687d4ee68a8e836e5c51a1fde0d28d019c0c66b9
2024-12-14 20:10:17 +01:00
# Specifying --(dis|en)able-elf-hack on a platform for which it's not implemented will give `--disable-elf-hack is not available in this configuration`
# This is declared here because it's used in the default value of elfhackSupport
buildMozillaMach: elf-hack is only available on elf platforms Followup to https://github.com/NixOS/nixpkgs/pull/365185 Probably darwin does not have the elf-hack options, so restrict it to platforms which have Elf. Change-Id: I2d585721ca08df57a7d2d55bb5a727d34b3fb216
2024-12-14 20:22:09 +01:00
isElfhackPlatform =
stdenv:
stdenv.hostPlatform.isElf
&& (
stdenv.hostPlatform.isi686
|| stdenv.hostPlatform.isx86_64
|| stdenv.hostPlatform.isAarch32
|| stdenv.hostPlatform.isAarch64
);
buildMozillaMach: allow overriding requireSigning/allowAddonSideload
2023-11-25 02:30:25 -05:00
in
firefox: refactor into firefoxPackages, add more options
2017-03-27 12:33:00 +00:00
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
{
lib,
buildMozillaMach: Add distribution identifier and distribution.ini Adds a distribution id useful for aggregation of crash statistics. Also creates a NixOS flavor, visible through the About window, that is also exposed through telemetry data, if enabled.
2022-05-16 00:26:57 +02:00
pkgs,
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
stdenv,
buildMozillaMach: add curl into crashreporter rpath Firefox has been crashy during the 106 cycle on my laptop, so I saw the crashreporter more often than not. In the terminal spew I found > Failed to open curl lib from binary, use libcurl.so instead and the GUI told me submitting the report had failed. Not great if you actually except to have your bugs fixed at some point.
2022-11-08 00:02:25 +01:00
patchelf,
treewide: Format all Nix files Format all Nix files using the officially approved formatter, making the CI check introduced in the previous commit succeed: nix-build ci -A fmt.check This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153) of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166). This commit will lead to merge conflicts for a number of PRs, up to an estimated ~1100 (~33%) among the PRs with activity in the past 2 months, but that should be lower than what it would be without the previous [partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537). Merge conflicts caused by this commit can now automatically be resolved while rebasing using the [auto-rebase script](https://github.com/NixOS/nixpkgs/tree/8616af08d915377bd930395f3b700a0e93d08728/maintainers/scripts/auto-rebase). If you run into any problems regarding any of this, please reach out to the [formatting team](https://nixos.org/community/teams/formatting/) by pinging @NixOS/nix-formatting.
2025-04-01 20:10:43 +02:00
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
# build time
autoconf,
cargo,
buildMozillaMach: create symbols output Thie zip bundle in this output is used in the dumps sent by the crashreporter. For this to happen we need to upload this zip file to https://symbols.mozilla.org, which is a separate effort.
2022-05-12 14:40:21 +02:00
dump_syms,
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
makeWrapper,
pkgsMusl.firefox: fix build
2022-08-15 11:50:26 +02:00
mimalloc,
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
nodejs,
perl,
pkg-config,
pkgsCross, # wasm32 rlbox
python3,
runCommand,
rustc,
rust-cbindgen,
rustPlatform,
unzip,
which,
treewide: wrapGAppsHook → wrapGAppsHook3 This was achieved using the following command: sd 'wrapGAppsHook\b' wrapGAppsHook3 (rg -l 'wrapGAppsHook\b') And then manually reverted the following changes: - alias in top-level.nix - function name in wrap-gapps-hook.sh - comment in postFixup of at-spi2-core - comment in gtk4 - comment in preFixup of 1password-gui/linux.nix - comment in postFixup of qgis/unwrapped-ltr.nix and qgis/unwrapped.nix - comment in postFixup of telegram-desktop - comment in postFixup of fwupd - buildCommand of mongodb-compass - postFixup of xflux-gui - comment in a patch in kdePackages.kde-gtk-config and plasma5Packages.kde-gtk-config - description of programs.sway.wrapperFeatures.gtk NixOS option (manual rebuild)
2024-04-26 22:24:03 +02:00
wrapGAppsHook3,
treewide: Format all Nix files Format all Nix files using the officially approved formatter, making the CI check introduced in the previous commit succeed: nix-build ci -A fmt.check This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153) of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166). This commit will lead to merge conflicts for a number of PRs, up to an estimated ~1100 (~33%) among the PRs with activity in the past 2 months, but that should be lower than what it would be without the previous [partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537). Merge conflicts caused by this commit can now automatically be resolved while rebasing using the [auto-rebase script](https://github.com/NixOS/nixpkgs/tree/8616af08d915377bd930395f3b700a0e93d08728/maintainers/scripts/auto-rebase). If you run into any problems regarding any of this, please reach out to the [formatting team](https://nixos.org/community/teams/formatting/) by pinging @NixOS/nix-formatting.
2025-04-01 20:10:43 +02:00
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
# runtime
bzip2,
dbus,
dbus-glib,
file,
fontconfig,
freetype,
glib,
gnum4,
gtk3,
buildMozillaMach: pin icu at 73 for now Pending https://bugzilla.mozilla.org/show_bug.cgi?id=1862601.
2024-06-27 14:50:47 +02:00
icu73,
thunderbird: fix calendar again after icu77 switch
2025-05-16 08:06:52 +02:00
icu77, # if you fiddle with the icu parameters, please check Thunderbird's overrides
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
libGL,
libGLU,
libevent,
firefox: fix system libffi usage Since Firefox 51 the --enable-system-ffi flag was renamed to --with-systemd-ffi when it moved to the javascript toolkit parts. Rename the flag accordingly and reintroduce the dependency. mozbz#1294803
2022-03-21 18:16:55 +01:00
libffi,
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
libjpeg,
libpng,
libstartup_notification,
firefox: use libvpx instead of libvpx_1_8
2021-11-29 17:09:07 +08:00
libvpx,
firefox: use our own libwebp
2022-03-21 03:45:46 +01:00
libwebp,
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
nasm,
nspr,
thunderbird{-bin}|firefox|librewolf: use nss_latest for regular releases and nss_esr for esr releases
2022-03-30 01:18:38 +02:00
nss_esr,
nss_latest,
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
pango,
xorg,
zip,
zlib,
firefox-unwrapped: fix cross compilation
2022-05-03 10:23:35 +08:00
pkgsBuildBuild,
treewide: Format all Nix files Format all Nix files using the officially approved formatter, making the CI check introduced in the previous commit succeed: nix-build ci -A fmt.check This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153) of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166). This commit will lead to merge conflicts for a number of PRs, up to an estimated ~1100 (~33%) among the PRs with activity in the past 2 months, but that should be lower than what it would be without the previous [partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537). Merge conflicts caused by this commit can now automatically be resolved while rebasing using the [auto-rebase script](https://github.com/NixOS/nixpkgs/tree/8616af08d915377bd930395f3b700a0e93d08728/maintainers/scripts/auto-rebase). If you run into any problems regarding any of this, please reach out to the [formatting team](https://nixos.org/community/teams/formatting/) by pinging @NixOS/nix-formatting.
2025-04-01 20:10:43 +02:00
firefox: enable darwin builds
2024-10-20 22:55:34 -04:00
# Darwin
apple-sdk_14,
buildMozillaMach: apple-sdk_14 -> apple-sdk_15 starting with version 138 0:01.18 ERROR: SDK version "14.4" is too old. Please upgrade to at least 15.2. Try updating your system Xcode. Newer versions of firefox require apple-sdk_15.
2025-04-19 15:08:02 -05:00
apple-sdk_15,
firefox: enable darwin builds
2024-10-20 22:55:34 -04:00
cups,
rsync, # used when preparing .app directory
treewide: Format all Nix files Format all Nix files using the officially approved formatter, making the CI check introduced in the previous commit succeed: nix-build ci -A fmt.check This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153) of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166). This commit will lead to merge conflicts for a number of PRs, up to an estimated ~1100 (~33%) among the PRs with activity in the past 2 months, but that should be lower than what it would be without the previous [partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537). Merge conflicts caused by this commit can now automatically be resolved while rebasing using the [auto-rebase script](https://github.com/NixOS/nixpkgs/tree/8616af08d915377bd930395f3b700a0e93d08728/maintainers/scripts/auto-rebase). If you run into any problems regarding any of this, please reach out to the [formatting team](https://nixos.org/community/teams/formatting/) by pinging @NixOS/nix-formatting.
2025-04-01 20:10:43 +02:00
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
# optionals
treewide: Format all Nix files Format all Nix files using the officially approved formatter, making the CI check introduced in the previous commit succeed: nix-build ci -A fmt.check This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153) of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166). This commit will lead to merge conflicts for a number of PRs, up to an estimated ~1100 (~33%) among the PRs with activity in the past 2 months, but that should be lower than what it would be without the previous [partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537). Merge conflicts caused by this commit can now automatically be resolved while rebasing using the [auto-rebase script](https://github.com/NixOS/nixpkgs/tree/8616af08d915377bd930395f3b700a0e93d08728/maintainers/scripts/auto-rebase). If you run into any problems regarding any of this, please reach out to the [formatting team](https://nixos.org/community/teams/formatting/) by pinging @NixOS/nix-formatting.
2025-04-01 20:10:43 +02:00
buildMozillaMach: allow overriding requireSigning/allowAddonSideload
2023-11-25 02:30:25 -05:00
## addon signing/sideloading
requireSigning ? requireSigningDefault,
allowAddonSideload ? allowAddonSideloadDefault,
treewide: Format all Nix files Format all Nix files using the officially approved formatter, making the CI check introduced in the previous commit succeed: nix-build ci -A fmt.check This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153) of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166). This commit will lead to merge conflicts for a number of PRs, up to an estimated ~1100 (~33%) among the PRs with activity in the past 2 months, but that should be lower than what it would be without the previous [partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537). Merge conflicts caused by this commit can now automatically be resolved while rebasing using the [auto-rebase script](https://github.com/NixOS/nixpkgs/tree/8616af08d915377bd930395f3b700a0e93d08728/maintainers/scripts/auto-rebase). If you run into any problems regarding any of this, please reach out to the [formatting team](https://nixos.org/community/teams/formatting/) by pinging @NixOS/nix-formatting.
2025-04-01 20:10:43 +02:00
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
## debugging
treewide: Format all Nix files Format all Nix files using the officially approved formatter, making the CI check introduced in the previous commit succeed: nix-build ci -A fmt.check This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153) of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166). This commit will lead to merge conflicts for a number of PRs, up to an estimated ~1100 (~33%) among the PRs with activity in the past 2 months, but that should be lower than what it would be without the previous [partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537). Merge conflicts caused by this commit can now automatically be resolved while rebasing using the [auto-rebase script](https://github.com/NixOS/nixpkgs/tree/8616af08d915377bd930395f3b700a0e93d08728/maintainers/scripts/auto-rebase). If you run into any problems regarding any of this, please reach out to the [formatting team](https://nixos.org/community/teams/formatting/) by pinging @NixOS/nix-formatting.
2025-04-01 20:10:43 +02:00
firefox: add an option to build with debugging enabled.
2013-10-05 21:07:42 -07:00
debugBuild ? false,
treewide: Format all Nix files Format all Nix files using the officially approved formatter, making the CI check introduced in the previous commit succeed: nix-build ci -A fmt.check This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153) of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166). This commit will lead to merge conflicts for a number of PRs, up to an estimated ~1100 (~33%) among the PRs with activity in the past 2 months, but that should be lower than what it would be without the previous [partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537). Merge conflicts caused by this commit can now automatically be resolved while rebasing using the [auto-rebase script](https://github.com/NixOS/nixpkgs/tree/8616af08d915377bd930395f3b700a0e93d08728/maintainers/scripts/auto-rebase). If you run into any problems regarding any of this, please reach out to the [formatting team](https://nixos.org/community/teams/formatting/) by pinging @NixOS/nix-formatting.
2025-04-01 20:10:43 +02:00
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
# On 32bit platforms, we disable adding "-g" for easier linking.
enableDebugSymbols ? !stdenv.hostPlatform.is32bit,
treewide: Format all Nix files Format all Nix files using the officially approved formatter, making the CI check introduced in the previous commit succeed: nix-build ci -A fmt.check This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153) of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166). This commit will lead to merge conflicts for a number of PRs, up to an estimated ~1100 (~33%) among the PRs with activity in the past 2 months, but that should be lower than what it would be without the previous [partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537). Merge conflicts caused by this commit can now automatically be resolved while rebasing using the [auto-rebase script](https://github.com/NixOS/nixpkgs/tree/8616af08d915377bd930395f3b700a0e93d08728/maintainers/scripts/auto-rebase). If you run into any problems regarding any of this, please reach out to the [formatting team](https://nixos.org/community/teams/formatting/) by pinging @NixOS/nix-formatting.
2025-04-01 20:10:43 +02:00
firefoxPackages: implement privacySupport option
2017-03-27 12:35:34 +00:00
## optional libraries
treewide: Format all Nix files Format all Nix files using the officially approved formatter, making the CI check introduced in the previous commit succeed: nix-build ci -A fmt.check This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153) of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166). This commit will lead to merge conflicts for a number of PRs, up to an estimated ~1100 (~33%) among the PRs with activity in the past 2 months, but that should be lower than what it would be without the previous [partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537). Merge conflicts caused by this commit can now automatically be resolved while rebasing using the [auto-rebase script](https://github.com/NixOS/nixpkgs/tree/8616af08d915377bd930395f3b700a0e93d08728/maintainers/scripts/auto-rebase). If you run into any problems regarding any of this, please reach out to the [formatting team](https://nixos.org/community/teams/formatting/) by pinging @NixOS/nix-formatting.
2025-04-01 20:10:43 +02:00
Change all alsaLib references to alsa-lib
2021-06-09 23:57:09 -03:00
alsaSupport ? stdenv.hostPlatform.isLinux,
alsa-lib,
firefoxen: remove unused gstreamer dependencies Firefox and, by extension, Tor browser don't support gstreamer any more, this removes what are effectively unused dependencies. https://bugzilla.mozilla.org/show_bug.cgi?id=1234092 "Remove gstreamer support"
2018-11-14 22:29:48 +00:00
ffmpegSupport ? true,
kerberos: deprecate alias
2021-03-14 17:11:48 +01:00
gssSupport ? true,
libkrb5,
firefox: support JACK and sndio audio backends You can set `media.cubeb.backend` in `about:config` to force a specific backend.
2022-05-07 18:31:10 -04:00
jackSupport ? stdenv.hostPlatform.isLinux,
libjack2,
pkgsMusl.firefox: fix build
2022-08-15 11:50:26 +02:00
jemallocSupport ? !stdenv.hostPlatform.isMusl,
jemalloc,
firefox-unwrapped: disable lto, crashreporter and webrtc support on RISC-V as they are not supported yet
2023-03-30 23:03:07 +08:00
ltoSupport ? (
stdenv.hostPlatform.isLinux && stdenv.hostPlatform.is64bit && !stdenv.hostPlatform.isRiscV
),
overrideCC,
buildPackages,
firefox: enable pgo on musl
2022-10-18 20:18:18 +02:00
pgoSupport ? (stdenv.hostPlatform.isLinux && stdenv.hostPlatform == stdenv.buildPlatform),
xvfb-run,
buildMozillaMach: re-enable elf-hack with LTO/LLD, disable with musl (#365185) The elfhack was completely revamped and is now implemented with the "relrhack", which is compatible with LLD: https://glandium.org/blog/?p=4297 Exposes a new option elfhackSupport and sets reasonable default based on the properties of the new relrhack. Change-Id: I687d4ee68a8e836e5c51a1fde0d28d019c0c66b9
2024-12-14 20:10:17 +01:00
elfhackSupport ?
isElfhackPlatform stdenv && !(stdenv.hostPlatform.isMusl && stdenv.hostPlatform.isAarch64),
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
pipewireSupport ? waylandSupport && webrtcSupport,
pulseaudioSupport ? stdenv.hostPlatform.isLinux,
libpulseaudio,
firefox: support JACK and sndio audio backends You can set `media.cubeb.backend` in `about:config` to force a specific backend.
2022-05-07 18:31:10 -04:00
sndioSupport ? stdenv.hostPlatform.isLinux,
sndio,
firefox, thunderbird: enable wrapped derivations for darwin It also aligns application names for wrapped and unwrapped flavors of the same derivations; and uses unique application names for each flavor, so it's now possible to install multiple versions on the same Darwin machine. One visible change now is that `About Firefox` window now shows: `Firefox for NixOS` instead of `Mozilla Firefox for NixOS` ...in the `distribution` field. I think it's fine and doesn't infringe on any trademarks because this field is not required to mention Mozilla at all, as per: https://wiki.mozilla.org/Distribution_INI_File While at it, also changed the branding for Darwin builds to list: `Firefox for Nix on MacOS` instead of `Firefox for NixOS` The telemetry and distribution ids (`nixos`) are left intact. Note: it's still not possible to install both source-based and -bin Darwin derivations in the same profile. It would require renaming applicationNames for these two different types to use unique names (e.g. `Firefox (Official)` or `Firefox (Binary)`, which doesn't seem optimal. Closes: #378433 Closes: #366581 Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
2025-01-29 20:35:46 -05:00
waylandSupport ? !stdenv.hostPlatform.isDarwin,
libxkbcommon,
libdrm,
treewide: Format all Nix files Format all Nix files using the officially approved formatter, making the CI check introduced in the previous commit succeed: nix-build ci -A fmt.check This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153) of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166). This commit will lead to merge conflicts for a number of PRs, up to an estimated ~1100 (~33%) among the PRs with activity in the past 2 months, but that should be lower than what it would be without the previous [partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537). Merge conflicts caused by this commit can now automatically be resolved while rebasing using the [auto-rebase script](https://github.com/NixOS/nixpkgs/tree/8616af08d915377bd930395f3b700a0e93d08728/maintainers/scripts/auto-rebase). If you run into any problems regarding any of this, please reach out to the [formatting team](https://nixos.org/community/teams/formatting/) by pinging @NixOS/nix-formatting.
2025-04-01 20:10:43 +02:00
firefoxPackages: implement privacySupport option
2017-03-27 12:35:34 +00:00
## privacy-related options
treewide: Format all Nix files Format all Nix files using the officially approved formatter, making the CI check introduced in the previous commit succeed: nix-build ci -A fmt.check This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153) of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166). This commit will lead to merge conflicts for a number of PRs, up to an estimated ~1100 (~33%) among the PRs with activity in the past 2 months, but that should be lower than what it would be without the previous [partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537). Merge conflicts caused by this commit can now automatically be resolved while rebasing using the [auto-rebase script](https://github.com/NixOS/nixpkgs/tree/8616af08d915377bd930395f3b700a0e93d08728/maintainers/scripts/auto-rebase). If you run into any problems regarding any of this, please reach out to the [formatting team](https://nixos.org/community/teams/formatting/) by pinging @NixOS/nix-formatting.
2025-04-01 20:10:43 +02:00
firefox: simplify derivation with firefox 64 being the latest version, and the removal of "tor-browser/icecat-like" variants, we can greatly simplify the common firefox derivation.
2020-02-01 18:56:13 +01:00
privacySupport ? false,
treewide: Format all Nix files Format all Nix files using the officially approved formatter, making the CI check introduced in the previous commit succeed: nix-build ci -A fmt.check This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153) of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166). This commit will lead to merge conflicts for a number of PRs, up to an estimated ~1100 (~33%) among the PRs with activity in the past 2 months, but that should be lower than what it would be without the previous [partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537). Merge conflicts caused by this commit can now automatically be resolved while rebasing using the [auto-rebase script](https://github.com/NixOS/nixpkgs/tree/8616af08d915377bd930395f3b700a0e93d08728/maintainers/scripts/auto-rebase). If you run into any problems regarding any of this, please reach out to the [formatting team](https://nixos.org/community/teams/formatting/) by pinging @NixOS/nix-formatting.
2025-04-01 20:10:43 +02:00
firefoxPackages: implement privacySupport option
2017-03-27 12:35:34 +00:00
# WARNING: NEVER set any of the options below to `true` by default.
firefox: re-enable webrtc on aarch64 (64+); fix comment
2019-04-06 23:49:14 +09:00
# Set to `!privacySupport` or `false`.
treewide: Format all Nix files Format all Nix files using the officially approved formatter, making the CI check introduced in the previous commit succeed: nix-build ci -A fmt.check This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153) of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166). This commit will lead to merge conflicts for a number of PRs, up to an estimated ~1100 (~33%) among the PRs with activity in the past 2 months, but that should be lower than what it would be without the previous [partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537). Merge conflicts caused by this commit can now automatically be resolved while rebasing using the [auto-rebase script](https://github.com/NixOS/nixpkgs/tree/8616af08d915377bd930395f3b700a0e93d08728/maintainers/scripts/auto-rebase). If you run into any problems regarding any of this, please reach out to the [formatting team](https://nixos.org/community/teams/formatting/) by pinging @NixOS/nix-formatting.
2025-04-01 20:10:43 +02:00
pkgsMusl.firefox: fix build
2022-08-15 11:50:26 +02:00
crashreporterSupport ?
buildMozillaMach: disable crash reporter support on loongarch64-linux (#403489)
2025-05-02 02:10:11 +02:00
!privacySupport
&& !stdenv.hostPlatform.isLoongArch64
&& !stdenv.hostPlatform.isRiscV
&& !stdenv.hostPlatform.isMusl,
pkgsMusl.firefox: fix build
2022-08-15 11:50:26 +02:00
curl,
Revert a part of "firefox: 56.0.2 -> 57.0" This reverts a part of commit 559433d0db3979f77befe73ad5c65b8500277629. The problem with removing those options completely is that without them tor-browser's config differs from the official config (which may or may not be a problem for fingerprinting).
2017-11-15 00:00:00 +00:00
geolocationSupport ? !privacySupport,
firefox: enable webrtcSupport on riscv
2024-03-25 16:49:20 -04:00
webrtcSupport ? !privacySupport,
treewide: Format all Nix files Format all Nix files using the officially approved formatter, making the CI check introduced in the previous commit succeed: nix-build ci -A fmt.check This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153) of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166). This commit will lead to merge conflicts for a number of PRs, up to an estimated ~1100 (~33%) among the PRs with activity in the past 2 months, but that should be lower than what it would be without the previous [partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537). Merge conflicts caused by this commit can now automatically be resolved while rebasing using the [auto-rebase script](https://github.com/NixOS/nixpkgs/tree/8616af08d915377bd930395f3b700a0e93d08728/maintainers/scripts/auto-rebase). If you run into any problems regarding any of this, please reach out to the [formatting team](https://nixos.org/community/teams/formatting/) by pinging @NixOS/nix-formatting.
2025-04-01 20:10:43 +02:00
firefox: fix drmSupport flag In #109133 @alyssais discovered that the drmSupport flag stopped working. This is because Mozilla decided around Firefox 51 (mozbz#1289634) to swap the default values and our flag was asking for the wrong thing all along. Since this flag has now been enabled for multiple years, disabling it would mean a regression for our users. Leaving it enabled should be unproblematic since it only controls whether Firefox shows the EME nagbar, that allows to enable Widevine CDM, when a site requests it. The choice is therefore completely up to the enduser. Disabling this nagbar is still possible at runtime by setting `browser.eme.ui.enabled` to `false`. If Widevine CDM was inadvertently enabled it can be disabled at `media.gmp-widevinecdm.enabled`. Supersedes: #109133
2022-03-28 15:26:04 +02:00
# digital rights managemewnt
treewide: Format all Nix files Format all Nix files using the officially approved formatter, making the CI check introduced in the previous commit succeed: nix-build ci -A fmt.check This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153) of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166). This commit will lead to merge conflicts for a number of PRs, up to an estimated ~1100 (~33%) among the PRs with activity in the past 2 months, but that should be lower than what it would be without the previous [partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537). Merge conflicts caused by this commit can now automatically be resolved while rebasing using the [auto-rebase script](https://github.com/NixOS/nixpkgs/tree/8616af08d915377bd930395f3b700a0e93d08728/maintainers/scripts/auto-rebase). If you run into any problems regarding any of this, please reach out to the [formatting team](https://nixos.org/community/teams/formatting/) by pinging @NixOS/nix-formatting.
2025-04-01 20:10:43 +02:00
firefox: fix drmSupport flag In #109133 @alyssais discovered that the drmSupport flag stopped working. This is because Mozilla decided around Firefox 51 (mozbz#1289634) to swap the default values and our flag was asking for the wrong thing all along. Since this flag has now been enabled for multiple years, disabling it would mean a regression for our users. Leaving it enabled should be unproblematic since it only controls whether Firefox shows the EME nagbar, that allows to enable Widevine CDM, when a site requests it. The choice is therefore completely up to the enduser. Disabling this nagbar is still possible at runtime by setting `browser.eme.ui.enabled` to `false`. If Widevine CDM was inadvertently enabled it can be disabled at `media.gmp-widevinecdm.enabled`. Supersedes: #109133
2022-03-28 15:26:04 +02:00
# This flag controls whether Firefox will show the nagbar, that allows
# users at runtime the choice to enable Widevine CDM support when a site
# requests it.
# Controlling the nagbar and widevine CDM at runtime is possible by setting
# `browser.eme.ui.enabled` and `media.gmp-widevinecdm.enabled` accordingly
drmSupport ? true,
treewide: Format all Nix files Format all Nix files using the officially approved formatter, making the CI check introduced in the previous commit succeed: nix-build ci -A fmt.check This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153) of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166). This commit will lead to merge conflicts for a number of PRs, up to an estimated ~1100 (~33%) among the PRs with activity in the past 2 months, but that should be lower than what it would be without the previous [partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537). Merge conflicts caused by this commit can now automatically be resolved while rebasing using the [auto-rebase script](https://github.com/NixOS/nixpkgs/tree/8616af08d915377bd930395f3b700a0e93d08728/maintainers/scripts/auto-rebase). If you run into any problems regarding any of this, please reach out to the [formatting team](https://nixos.org/community/teams/formatting/) by pinging @NixOS/nix-formatting.
2025-04-01 20:10:43 +02:00
firefox: enable official branding As stated by Sylvestre Ledru (@sylvestre) on Nov 22, 2017 at https://github.com/NixOS/nixpkgs/issues/31843#issuecomment-346372756 we have permission to use the official firefox branding. Fur purposes of documentation the statement of @sylvestre: > As the person who did part of the work described in the LWN article > and release manager working for Mozilla, I can confirm the statement > that I made in > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=815006 > > @garbas shared with me the list of patches applied for the Nix package. > As they are just for portability and tiny modifications, they don't > alter the experience of the product. In parallel, Rok also shared the > build options. They seem good (even if I cannot judge the quality of the > packaging of the underlying dependencies like sqlite, png, etc). > Therefor, as long as you keep the patch queue sane and you don't alter > the experience of Firefox users, you won't have any issues using the > official branding.
2018-01-31 17:50:10 +01:00
# As stated by Sylvestre Ledru (@sylvestre) on Nov 22, 2017 at
# https://github.com/NixOS/nixpkgs/issues/31843#issuecomment-346372756 we
# have permission to use the official firefox branding.
#
firefox: fix typo in comment in common.nix
2020-07-24 09:49:43 +02:00
# For purposes of documentation the statement of @sylvestre:
firefox: enable official branding As stated by Sylvestre Ledru (@sylvestre) on Nov 22, 2017 at https://github.com/NixOS/nixpkgs/issues/31843#issuecomment-346372756 we have permission to use the official firefox branding. Fur purposes of documentation the statement of @sylvestre: > As the person who did part of the work described in the LWN article > and release manager working for Mozilla, I can confirm the statement > that I made in > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=815006 > > @garbas shared with me the list of patches applied for the Nix package. > As they are just for portability and tiny modifications, they don't > alter the experience of the product. In parallel, Rok also shared the > build options. They seem good (even if I cannot judge the quality of the > packaging of the underlying dependencies like sqlite, png, etc). > Therefor, as long as you keep the patch queue sane and you don't alter > the experience of Firefox users, you won't have any issues using the > official branding.
2018-01-31 17:50:10 +01:00
# > As the person who did part of the work described in the LWN article
# > and release manager working for Mozilla, I can confirm the statement
# > that I made in
# > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=815006
# >
# > @garbas shared with me the list of patches applied for the Nix package.
# > As they are just for portability and tiny modifications, they don't
# > alter the experience of the product. In parallel, Rok also shared the
# > build options. They seem good (even if I cannot judge the quality of the
# > packaging of the underlying dependencies like sqlite, png, etc).
# > Therefor, as long as you keep the patch queue sane and you don't alter
# > the experience of Firefox users, you won't have any issues using the
# > official branding.
enableOfficialBranding ? true,
firefox: Update to 21.0 Only problem was that the chrome resources were not in the right place (and you only see that by running with the -jsconsole flag).
2013-06-06 13:07:54 +02:00
}:
firefox: common: tiny cleanup
2018-02-01 00:00:00 +00:00
assert stdenv.cc.libc or null != null;
firefox: add pname to throw message https://github.com/NixOS/nixpkgs/pull/164646#discussion_r835879348
2022-03-27 15:10:43 +02:00
assert
pipewireSupport
-> !waylandSupport || !webrtcSupport
-> throw "${pname}: pipewireSupport requires both wayland and webrtc support.";
buildMozillaMach: re-enable elf-hack with LTO/LLD, disable with musl (#365185) The elfhack was completely revamped and is now implemented with the "relrhack", which is compatible with LLD: https://glandium.org/blog/?p=4297 Exposes a new option elfhackSupport and sets reasonable default based on the properties of the new relrhack. Change-Id: I687d4ee68a8e836e5c51a1fde0d28d019c0c66b9
2024-12-14 20:10:17 +01:00
assert elfhackSupport -> isElfhackPlatform stdenv;
firefox: Update to 21.0 Only problem was that the chrome resources were not in the right place (and you only see that by running with the -jsconsole flag).
2013-06-06 13:07:54 +02:00
Add firefox-esr
2015-09-03 10:54:13 +02:00
let
buildMozillaMach: use enableFeature instead of recreating it
2022-11-24 15:56:43 -03:00
inherit (lib) enableFeature;
firefox: build on darwin Fixes #30285
2018-07-10 18:10:04 -04:00
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
# Target the LLVM version that rustc is built with for LTO.
firefox: drop darwin support Darwin support was marked broken in 2019 with Firefox 69 and has missed therefore missed out and not been tested on the following 29 major releases since. It cannot be supported again without a darwin user stepping up to take care and work on and test every major release, which hasn't happened since I took over maintainership. The recommendation of the people that tend to the firefox source build is for darwin users to use firefox-bin instead.
2022-03-21 16:03:59 +01:00
llvmPackages0 = rustc.llvmPackages;
firefox-unwrapped: fix cross compilation
2022-05-03 10:23:35 +08:00
llvmPackagesBuildBuild0 = pkgsBuildBuild.rustc.llvmPackages;
firefox-esr-78: drop Firefox ESR 78.15 was the last release of this series and is now EOL.
2021-11-02 10:39:56 +01:00
treewide: All the linker to be chosen independently This will begin the process of breaking up the `useLLVM` monolith. That is good in general, but I hope will be good for NetBSD and Darwin in particular. Co-authored-by: sterni <sternenseemann@systemli.org>
2021-05-01 03:03:19 +00:00
# Force the use of lld and other llvm tools for LTO
llvmPackages = llvmPackages0.override {
bootBintoolsNoLibc = null;
bootBintools = null;
};
firefox-unwrapped: fix cross compilation
2022-05-03 10:23:35 +08:00
llvmPackagesBuildBuild = llvmPackagesBuildBuild0.override {
bootBintoolsNoLibc = null;
bootBintools = null;
};
firefox: add ltoSupport and enable it by default
2020-10-06 14:14:06 -04:00
firefox: always build with clang Both LTO and PGO require the use of clang so I think its easier to just stick with clang for all builds, so PGO and LTO could in theory be used without each other.
2022-03-27 17:12:20 +02:00
# LTO requires LLVM bintools including ld.lld and llvm-ar.
buildStdenv = overrideCC llvmPackages.stdenv (
llvmPackages.stdenv.cc.override {
firefox-unwrapped: fix cross compilation
2022-05-03 10:23:35 +08:00
bintools = if ltoSupport then buildPackages.rustc.llvmPackages.bintools else stdenv.cc.bintools;
firefox: always build with clang Both LTO and PGO require the use of clang so I think its easier to just stick with clang for all builds, so PGO and LTO could in theory be used without each other.
2022-03-27 17:12:20 +02:00
}
);
firefox-esr: fix build by using older rust It's probably the same issue as with thunderbird.
2020-11-07 14:53:42 +01:00
firefox: enable RLBox sandboxing https://hacks.mozilla.org/2021/12/webassembly-and-back-again-fine-grained-sandboxing-in-firefox-95/ Co-authored-by: Jörg Thalheim <joerg@thalheim.io>
2022-03-09 19:40:08 +01:00
# Compile the wasm32 sysroot to build the RLBox Sandbox
# https://hacks.mozilla.org/2021/12/webassembly-and-back-again-fine-grained-sandboxing-in-firefox-95/
# We only link c++ libs here, our compiler wrapper can find wasi libc and crt itself.
wasiSysRoot = runCommand "wasi-sysroot" { } ''
mkdir -p $out/lib/wasm32-wasi
llvmPackages_{12,13,14,15,16,17,git}.{libcxx,libcxxabi}: merge libcxxabi into libcxx (#292043) - merge libcxxabi into libcxx for LLVM 12, 13, 14, 15, 16, 17, and git. - remove the link time workaround `-lc++ -lc++abi` from 58 packages as it is no longer required. - fixes https://github.com/NixOS/nixpkgs/issues/166205 - provides alternative fixes for. https://github.com/NixOS/nixpkgs/issues/269548 https://github.com/NixOS/nix/issues/9640 - pkgsCross.x86_64-freebsd builds work again This change can be represented in 3 stages 1. merge libcxxabi into libcxx -- files: pkgs/development/compilers/llvm/[12, git]/{libcxx, libcxxabi} 2. update stdenv to account for merge -- files: stdenv.{adapters, cc.wrapper, darwin} 3. remove all references to libcxxabi outside of llvm (about 58 packages modified) ### merging libcxxabi into libcxx - take the union of the libcxxabi and libcxx cmake flags - eliminate the libcxx-headers-only package - it was only needed to break libcxx <-> libcxxabi circular dependency - libcxx.cxxabi is removed. external cxxabi (freebsd) will symlink headers / libs into libcxx. - darwin will re-export the libcxxabi symbols into libcxx so linking `-lc++` is sufficient. - linux/freebsd `libc++.so` is a linker script `LINK(libc++.so.1, -lc++abi)` making `-lc++` sufficient. - libcxx/default.nix [12, 17] are identical except for patches and `LIBCXX_ADDITIONAL_LIBRARIES` (only used in 16+) - git/libcxx/defaul.nix does not link with -nostdlib when useLLVM is true so flag is removed. this is not much different than before as libcxxabi used -nostdlib where libcxx did not, so libc was linked in anyway. ### stdenv changes - darwin bootstrap, remove references to libcxxabi and cxxabi - cc-wrapper: remove c++ link workaround when libcxx.cxxabi doesn't exist (still exists for LLVM pre 12) - adapter: update overrideLibcxx to account for a pkgs.stdenv that only has libcxx ### 58 package updates - remove `NIX_LDFLAGS = "-l${stdenv.cc.libcxx.cxxabi.libName}` as no longer needed - swift, nodejs_v8 remove libcxxabi references in the clang override https://github.com/NixOS/nixpkgs/pull/292043
2024-03-11 03:53:37 -07:00
for lib in ${pkgsCross.wasi32.llvmPackages.libcxx}/lib/*; do
firefox: enable RLBox sandboxing https://hacks.mozilla.org/2021/12/webassembly-and-back-again-fine-grained-sandboxing-in-firefox-95/ Co-authored-by: Jörg Thalheim <joerg@thalheim.io>
2022-03-09 19:40:08 +01:00
ln -s $lib $out/lib/wasm32-wasi
done
'';
buildMozillaMach: Add distribution identifier and distribution.ini Adds a distribution id useful for aggregation of crash statistics. Also creates a NixOS flavor, visible through the About window, that is also exposed through telemetry data, if enabled.
2022-05-16 00:26:57 +02:00
firefox, thunderbird: enable wrapped derivations for darwin It also aligns application names for wrapped and unwrapped flavors of the same derivations; and uses unique application names for each flavor, so it's now possible to install multiple versions on the same Darwin machine. One visible change now is that `About Firefox` window now shows: `Firefox for NixOS` instead of `Mozilla Firefox for NixOS` ...in the `distribution` field. I think it's fine and doesn't infringe on any trademarks because this field is not required to mention Mozilla at all, as per: https://wiki.mozilla.org/Distribution_INI_File While at it, also changed the branding for Darwin builds to list: `Firefox for Nix on MacOS` instead of `Firefox for NixOS` The telemetry and distribution ids (`nixos`) are left intact. Note: it's still not possible to install both source-based and -bin Darwin derivations in the same profile. It would require renaming applicationNames for these two different types to use unique names (e.g. `Firefox (Official)` or `Firefox (Binary)`, which doesn't seem optimal. Closes: #378433 Closes: #366581 Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
2025-01-29 20:35:46 -05:00
distributionIni =
let
platform = if stdenv.hostPlatform.isDarwin then "Nix on MacOS" else "NixOS";
in
pkgs.writeText "distribution.ini" (
lib.generators.toINI { } {
buildMozillaMach: Add distribution identifier and distribution.ini Adds a distribution id useful for aggregation of crash statistics. Also creates a NixOS flavor, visible through the About window, that is also exposed through telemetry data, if enabled.
2022-05-16 00:26:57 +02:00
# Some light branding indicating this build uses our distro preferences
Global = {
id = "nixos";
version = "1.0";
firefox, thunderbird: enable wrapped derivations for darwin It also aligns application names for wrapped and unwrapped flavors of the same derivations; and uses unique application names for each flavor, so it's now possible to install multiple versions on the same Darwin machine. One visible change now is that `About Firefox` window now shows: `Firefox for NixOS` instead of `Mozilla Firefox for NixOS` ...in the `distribution` field. I think it's fine and doesn't infringe on any trademarks because this field is not required to mention Mozilla at all, as per: https://wiki.mozilla.org/Distribution_INI_File While at it, also changed the branding for Darwin builds to list: `Firefox for Nix on MacOS` instead of `Firefox for NixOS` The telemetry and distribution ids (`nixos`) are left intact. Note: it's still not possible to install both source-based and -bin Darwin derivations in the same profile. It would require renaming applicationNames for these two different types to use unique names (e.g. `Firefox (Official)` or `Firefox (Binary)`, which doesn't seem optimal. Closes: #378433 Closes: #366581 Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
2025-01-29 20:35:46 -05:00
about = "${applicationName} for ${platform}";
buildMozillaMach: Add distribution identifier and distribution.ini Adds a distribution id useful for aggregation of crash statistics. Also creates a NixOS flavor, visible through the About window, that is also exposed through telemetry data, if enabled.
2022-05-16 00:26:57 +02:00
};
Preferences = {
# These values are exposed through telemetry
"app.distributor" = "nixos";
"app.distributor.channel" = "nixpkgs";
};
}
);
buildMozillaMach: disable geoclue when geolocation support is disabled This was an oversight since support for geoclue was added in Firefox 102.
2025-04-30 23:51:42 +02:00
defaultPrefs =
if geolocationSupport then
{
"geo.provider.network.url" = {
value = "https://api.beacondb.net/v1/geolocate";
reason = "We have no Google API keys and Mozilla Location Services were retired.";
};
}
else
{
"geo.provider.use_geoclue" = {
value = false;
reason = "Geolocation support has been disabled through the `geolocationSupport` package attribute.";
};
};
buildMozillaMach: set geo.provider.network.url for new profiles. Use Mozilla Location Service as geolocation provider for new profiles, since our Google API key does not seem to work for geolocation at this time. Related: https://github.com/NixOS/nixpkgs/issues/173758
2022-05-22 01:49:20 +02:00
defaultPrefsFile = pkgs.writeText "nixos-default-prefs.js" (
lib.concatStringsSep "\n" (
lib.mapAttrsToList (key: value: ''
// ${value.reason}
pref("${key}", ${builtins.toJSON value.value});
'') defaultPrefs
treewide: Format all Nix files Format all Nix files using the officially approved formatter, making the CI check introduced in the previous commit succeed: nix-build ci -A fmt.check This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153) of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166). This commit will lead to merge conflicts for a number of PRs, up to an estimated ~1100 (~33%) among the PRs with activity in the past 2 months, but that should be lower than what it would be without the previous [partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537). Merge conflicts caused by this commit can now automatically be resolved while rebasing using the [auto-rebase script](https://github.com/NixOS/nixpkgs/tree/8616af08d915377bd930395f3b700a0e93d08728/maintainers/scripts/auto-rebase). If you run into any problems regarding any of this, please reach out to the [formatting team](https://nixos.org/community/teams/formatting/) by pinging @NixOS/nix-formatting.
2025-04-01 20:10:43 +02:00
)
buildMozillaMach: set geo.provider.network.url for new profiles. Use Mozilla Location Service as geolocation provider for new profiles, since our Google API key does not seem to work for geolocation at this time. Related: https://github.com/NixOS/nixpkgs/issues/173758
2022-05-22 01:49:20 +02:00
);
firefox: enable darwin builds
2024-10-20 22:55:34 -04:00
toolkit =
if stdenv.hostPlatform.isDarwin then
"cairo-cocoa"
else
"cairo-gtk3${lib.optionalString waylandSupport "-wayland"}";
firefox: simplify derivation with firefox 64 being the latest version, and the removal of "tor-browser/icecat-like" variants, we can greatly simplify the common firefox derivation.
2020-02-01 18:56:13 +01:00
in
buildMozillaMach: don't use lib.optional with a list
2023-06-22 19:04:37 -04:00
buildStdenv.mkDerivation {
firefox-unwrapped: use pname+version
2022-08-02 14:22:42 +02:00
pname = "${pname}-unwrapped";
buildMozillaMach: allow distinct source and package versions Signed-off-by: Christoph Heiss <christoph@c8h4.io>
2023-10-10 17:35:11 +02:00
version = packageVersion;
firefoxPackages.icecat: init at 60.3.0, 52.6.0 It works, but this state is far from ideal: GNU guys update generated source tarballs very infrequently. Ideally, src needs to be generated by running makeicecat over firefox src. Will do later.
2019-01-01 00:00:00 +00:00
firefox: simplify derivation with firefox 64 being the latest version, and the removal of "tor-browser/icecat-like" variants, we can greatly simplify the common firefox derivation.
2020-02-01 18:56:13 +01:00
inherit src unpackPhase meta;
firefoxPackages: move nixpkgsPatches into common.nix
2019-01-31 16:38:01 +00:00
buildMozillaMach: create symbols output Thie zip bundle in this output is used in the dumps sent by the crashreporter. For this to happen we need to upload this zip file to https://symbols.mozilla.org, which is a separate effort.
2022-05-12 14:40:21 +02:00
outputs = [
"out"
buildMozillaMach: fix builds with crash reporting disabled - only try to build and copy crash reporting symbols when crash reporting is enabled - fixes the librewolf build
2022-05-16 13:52:15 -07:00
] ++ lib.optionals crashreporterSupport [ "symbols" ];
buildMozillaMach: create symbols output Thie zip bundle in this output is used in the dumps sent by the crashreporter. For this to happen we need to upload this zip file to https://symbols.mozilla.org, which is a separate effort.
2022-05-12 14:40:21 +02:00
firefox: add profile-guided optimization Lo and behold, we're finally catching up with Mozillas very own firefox build in terms of speed. PGO is an optimization technique in which in a first step we create a build that supports instrumentation, meaning we can use it to create a profile of how the browser behaved during usage. Then in a second pass we create the final build that uses the acquired profiling data to optimize the browser for the workload it actually received during profiling. The downside is that with PGO we now need to build Firefox twice, which increases the build time from around 20 minutes to roughly 50 minutes. In the Speedometer 2.0 benchmark multiple tests could see a responsiveness improvemeant around 20-25%, which makes the increased build time well worth it. Sadly this benefit seems limited to x86_64-linux, builds on aarch64-linux get stuck during profiling and I haven't found out why. Finally, after a long time, we can say: Closes: #76484 Supersedes: #129503
2022-03-22 03:35:51 +01:00
# Add another configure-build-profiling run before the final configure phase if we build with pgo
preConfigurePhases = lib.optionals pgoSupport [
"configurePhase"
"buildPhase"
"profilingPhase"
];
buildMozillaMach: update system dir patch for Firefox 133+ Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
2024-10-29 21:28:50 +01:00
patches =
lib.optionals (lib.versionAtLeast version "111" && lib.versionOlder version "133") [
./env_var_for_system_dir-ff111.patch
]
++ lib.optionals (lib.versionAtLeast version "133") [ ./env_var_for_system_dir-ff133.patch ]
firefox-unwrapped: 135.0.1 -> 136.0 https://www.mozilla.org/en-US/firefox/136.0/releasenotes/ https://www.mozilla.org/security/advisories/mfsa2025-14 Fixes: CVE-2025-1930, CVE-2025-1931, CVE-2025-1933, CVE-2025-1934, CVE-2025-1942, CVE-2025-1935, CVE-2025-1936, CVE-2025-1937, CVE-2025-1938, CVE-2025-1943
2025-03-03 23:17:00 +01:00
++ lib.optionals (lib.versionAtLeast version "121" && lib.versionOlder version "136") [
./no-buildconfig-ffx121.patch
treewide: Format all Nix files Format all Nix files using the officially approved formatter, making the CI check introduced in the previous commit succeed: nix-build ci -A fmt.check This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153) of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166). This commit will lead to merge conflicts for a number of PRs, up to an estimated ~1100 (~33%) among the PRs with activity in the past 2 months, but that should be lower than what it would be without the previous [partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537). Merge conflicts caused by this commit can now automatically be resolved while rebasing using the [auto-rebase script](https://github.com/NixOS/nixpkgs/tree/8616af08d915377bd930395f3b700a0e93d08728/maintainers/scripts/auto-rebase). If you run into any problems regarding any of this, please reach out to the [formatting team](https://nixos.org/community/teams/formatting/) by pinging @NixOS/nix-formatting.
2025-04-01 20:10:43 +02:00
]
firefox-unwrapped: 135.0.1 -> 136.0 https://www.mozilla.org/en-US/firefox/136.0/releasenotes/ https://www.mozilla.org/security/advisories/mfsa2025-14 Fixes: CVE-2025-1930, CVE-2025-1931, CVE-2025-1933, CVE-2025-1934, CVE-2025-1942, CVE-2025-1935, CVE-2025-1936, CVE-2025-1937, CVE-2025-1938, CVE-2025-1943
2025-03-03 23:17:00 +01:00
++ lib.optionals (lib.versionAtLeast version "136") [ ./no-buildconfig-ffx136.patch ]
firefox-unwrapped: 138.0.4 -> 139.0 https://www.mozilla.org/en-US/firefox/139.0/releasenotes/
2025-05-26 22:05:27 +02:00
++ lib.optionals (lib.versionAtLeast version "139") [ ./139-relax-apple-sdk.patch ]
++ lib.optionals (lib.versionOlder version "139") [
firefox: fix darwin build
2024-12-29 17:57:37 -05:00
# Fix for missing vector header on macOS
buildMozillaMach: remove obsolete patches
2025-05-10 20:19:10 -04:00
# https://bugzilla.mozilla.org/show_bug.cgi?id=1959377
# Fixed on Firefox 139
firefox: fix darwin build
2024-12-29 17:57:37 -05:00
./firefox-mac-missing-vector-header.patch
firefox-unwrapped: 138.0.4 -> 139.0 https://www.mozilla.org/en-US/firefox/139.0/releasenotes/
2025-05-26 22:05:27 +02:00
]
++ lib.optionals (lib.versionOlder version "140") [
buildMozillaMach: add RELRHACK_LINKER patch Needed to fix cross compiling. Patch also sent upstream: https://phabricator.services.mozilla.com/D246545
2025-04-23 21:47:11 -07:00
# https://bugzilla.mozilla.org/show_bug.cgi?id=1962497
# https://phabricator.services.mozilla.com/D246545
buildMozillaMach: remove obsolete patches
2025-05-10 20:19:10 -04:00
# Fixed on Firefox 140
buildMozillaMach: add RELRHACK_LINKER patch Needed to fix cross compiling. Patch also sent upstream: https://phabricator.services.mozilla.com/D246545
2025-04-23 21:47:11 -07:00
./build-fix-RELRHACK_LINKER-setting-when-linker-name-i.patch
buildMozillaMach: apply upstream WASI SDK workaround for LLVM 19 I have no idea why this is necessary for us and why the upstream patch doesn’t work, but this gets the Mozilla packages building on LLVM 19 in the meantime while we try to figure that out. Closes: #352724
2024-11-07 01:20:18 +00:00
]
firefox: rename patches arg to extraPatches This is for consistency with other extra arguments that can be handed to firefox common.nix. Also pull the patch phase of the derivation closer together and use the same list concat style as elsewhere.
2022-03-21 03:44:02 +01:00
++ extraPatches;
treewide: Format all Nix files Format all Nix files using the officially approved formatter, making the CI check introduced in the previous commit succeed: nix-build ci -A fmt.check This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153) of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166). This commit will lead to merge conflicts for a number of PRs, up to an estimated ~1100 (~33%) among the PRs with activity in the past 2 months, but that should be lower than what it would be without the previous [partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537). Merge conflicts caused by this commit can now automatically be resolved while rebasing using the [auto-rebase script](https://github.com/NixOS/nixpkgs/tree/8616af08d915377bd930395f3b700a0e93d08728/maintainers/scripts/auto-rebase). If you run into any problems regarding any of this, please reach out to the [formatting team](https://nixos.org/community/teams/formatting/) by pinging @NixOS/nix-formatting.
2025-04-01 20:10:43 +02:00
firefox: rename patches arg to extraPatches This is for consistency with other extra arguments that can be handed to firefox common.nix. Also pull the patch phase of the derivation closer together and use the same list concat style as elsewhere.
2022-03-21 03:44:02 +01:00
postPatch =
''
rm -rf obj-x86_64-pc-linux-gnu
firefox*: 107.0.1 -> 108.0 https://www.mozilla.org/en-US/firefox/108.0/releasenotes/ ./build/cargo-link uses /usr/bin/env shebang and thus needs patching.
2022-12-12 17:10:29 +01:00
patchShebangs mach build
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
''
buildMozillaMach: reenable system-icu By appling a patch from chaotic-nyx linking against icu76 and newer works again. From Firefox 139 upstream uses icu77, but it already works today on 138.0.1. https://bugzilla.mozilla.org/show_bug.cgi?id=1927380
2025-05-12 03:49:34 +02:00
# https://bugzilla.mozilla.org/show_bug.cgi?id=1927380
+ lib.optionalString (lib.versionAtLeast version "134") ''
sed -i "s/icu-i18n/icu-uc &/" js/moz.configure
''
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
+ extraPostPatch;
firefox: refactor into firefoxPackages, add more options
2017-03-27 12:33:00 +00:00
firefoxPackages: support building with firefox 65 Firefox >=65 will depend on icu >=63. All the older firefox versions (and derived packages) seem to work fine with this change. Also the system path environment patch will fail to apply since there was a trivial whitespace change in the source file. By adding `-l` to patch we can avoid having to track two patches that do basically the same. Having patchFlags per file without resorting to pre-/postPatch would be nicer but there doesn't seem to be a facility for that right now.
2019-01-23 01:04:04 +01:00
# Ignore trivial whitespace changes in patches, this fixes compatibility of
firefox: enable darwin builds
2024-10-20 22:55:34 -04:00
# ./env_var_for_system_dir-*.patch with Firefox >=65 without having to track
firefoxPackages: support building with firefox 65 Firefox >=65 will depend on icu >=63. All the older firefox versions (and derived packages) seem to work fine with this change. Also the system path environment patch will fail to apply since there was a trivial whitespace change in the source file. By adding `-l` to patch we can avoid having to track two patches that do basically the same. Having patchFlags per file without resorting to pre-/postPatch would be nicer but there doesn't seem to be a facility for that right now.
2019-01-23 01:04:04 +01:00
# two patches.
patchFlags = [
"-p1"
"-l"
];
firefox-unwrapped: fix cross compilation
2022-05-03 10:23:35 +08:00
# if not explicitly set, wrong cc from buildStdenv would be used
HOST_CC = "${llvmPackagesBuildBuild.stdenv.cc}/bin/cc";
HOST_CXX = "${llvmPackagesBuildBuild.stdenv.cc}/bin/c++";
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
nativeBuildInputs =
[
autoconf
cargo
firefox-unwrapped: fix cross compilation
2022-05-03 10:23:35 +08:00
gnum4
llvmPackagesBuildBuild.bintools
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
makeWrapper
nodejs
perl
python3
rust-cbindgen
rustPlatform.bindgenHook
rustc
unzip
which
treewide: wrapGAppsHook → wrapGAppsHook3 This was achieved using the following command: sd 'wrapGAppsHook\b' wrapGAppsHook3 (rg -l 'wrapGAppsHook\b') And then manually reverted the following changes: - alias in top-level.nix - function name in wrap-gapps-hook.sh - comment in postFixup of at-spi2-core - comment in gtk4 - comment in preFixup of 1password-gui/linux.nix - comment in postFixup of qgis/unwrapped-ltr.nix and qgis/unwrapped.nix - comment in postFixup of telegram-desktop - comment in postFixup of fwupd - buildCommand of mongodb-compass - postFixup of xflux-gui - comment in a patch in kdePackages.kde-gtk-config and plasma5Packages.kde-gtk-config - description of programs.sway.wrapperFeatures.gtk NixOS option (manual rebuild)
2024-04-26 22:24:03 +02:00
wrapGAppsHook3
firefox: refactor into firefoxPackages, add more options
2017-03-27 12:33:00 +00:00
]
firefox: enable darwin builds
2024-10-20 22:55:34 -04:00
++ lib.optionals (!stdenv.hostPlatform.isDarwin) [ pkg-config ]
++ lib.optionals stdenv.hostPlatform.isDarwin [ rsync ]
firefox-unwrapped: Move nasm to nativeBuildInputs Fixes cross compiling to x86.
2025-04-23 17:03:26 -07:00
++ lib.optionals stdenv.hostPlatform.isx86 [ nasm ]
buildMozillaMach: add curl into crashreporter rpath Firefox has been crashy during the 106 cycle on my laptop, so I saw the crashreporter more often than not. In the terminal spew I found > Failed to open curl lib from binary, use libcurl.so instead and the GUI told me submitting the report had failed. Not great if you actually except to have your bugs fixed at some point.
2022-11-08 00:02:25 +01:00
++ lib.optionals crashreporterSupport [
dump_syms
patchelf
]
firefox: add profile-guided optimization Lo and behold, we're finally catching up with Mozillas very own firefox build in terms of speed. PGO is an optimization technique in which in a first step we create a build that supports instrumentation, meaning we can use it to create a profile of how the browser behaved during usage. Then in a second pass we create the final build that uses the acquired profiling data to optimize the browser for the workload it actually received during profiling. The downside is that with PGO we now need to build Firefox twice, which increases the build time from around 20 minutes to roughly 50 minutes. In the Speedometer 2.0 benchmark multiple tests could see a responsiveness improvemeant around 20-25%, which makes the increased build time well worth it. Sadly this benefit seems limited to x86_64-linux, builds on aarch64-linux get stuck during profiling and I haven't found out why. Finally, after a long time, we can say: Closes: #76484 Supersedes: #129503
2022-03-22 03:35:51 +01:00
++ lib.optionals pgoSupport [ xvfb-run ]
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
++ extraNativeBuildInputs;
firefox: refactor into firefoxPackages, add more options
2017-03-27 12:33:00 +00:00
firefox: enable separated debug symbols
2021-11-16 18:38:56 +08:00
setOutputFlags = false; # `./mach configure` doesn't understand `--*dir=` flags.
firefox: refactor into firefoxPackages, add more options
2017-03-27 12:33:00 +00:00
preConfigure =
''
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
# Runs autoconf through ./mach configure in configurePhase
firefox: common: cleanup configure phase
2018-02-01 00:00:00 +00:00
configureScript="$(realpath ./mach) configure"
treewide: Format all Nix files Format all Nix files using the officially approved formatter, making the CI check introduced in the previous commit succeed: nix-build ci -A fmt.check This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153) of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166). This commit will lead to merge conflicts for a number of PRs, up to an estimated ~1100 (~33%) among the PRs with activity in the past 2 months, but that should be lower than what it would be without the previous [partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537). Merge conflicts caused by this commit can now automatically be resolved while rebasing using the [auto-rebase script](https://github.com/NixOS/nixpkgs/tree/8616af08d915377bd930395f3b700a0e93d08728/maintainers/scripts/auto-rebase). If you run into any problems regarding any of this, please reach out to the [formatting team](https://nixos.org/community/teams/formatting/) by pinging @NixOS/nix-formatting.
2025-04-01 20:10:43 +02:00
buildMozillaMach: use fixed build date This makes building w/o PGO reproducible.
2024-01-30 23:52:12 +01:00
# Set reproducible build date; https://bugzilla.mozilla.org/show_bug.cgi?id=885777#c21
export MOZ_BUILD_DATE=$(head -n1 sourcestamp.txt)
treewide: Format all Nix files Format all Nix files using the officially approved formatter, making the CI check introduced in the previous commit succeed: nix-build ci -A fmt.check This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153) of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166). This commit will lead to merge conflicts for a number of PRs, up to an estimated ~1100 (~33%) among the PRs with activity in the past 2 months, but that should be lower than what it would be without the previous [partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537). Merge conflicts caused by this commit can now automatically be resolved while rebasing using the [auto-rebase script](https://github.com/NixOS/nixpkgs/tree/8616af08d915377bd930395f3b700a0e93d08728/maintainers/scripts/auto-rebase). If you run into any problems regarding any of this, please reach out to the [formatting team](https://nixos.org/community/teams/formatting/) by pinging @NixOS/nix-formatting.
2025-04-01 20:10:43 +02:00
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
# Set predictable directories for build and state
buildMozillaMach: stop polluting the hg tree Moves the MOZ_OBJDIR into a path that is ignored through .hgignore, and the MOZBUILD_STATE_PATH outside of the source root. Closes: #306937
2024-04-28 16:13:25 +02:00
export MOZ_OBJDIR=$(pwd)/objdir
export MOZBUILD_STATE_PATH=$TMPDIR/mozbuild
treewide: Format all Nix files Format all Nix files using the officially approved formatter, making the CI check introduced in the previous commit succeed: nix-build ci -A fmt.check This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153) of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166). This commit will lead to merge conflicts for a number of PRs, up to an estimated ~1100 (~33%) among the PRs with activity in the past 2 months, but that should be lower than what it would be without the previous [partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537). Merge conflicts caused by this commit can now automatically be resolved while rebasing using the [auto-rebase script](https://github.com/NixOS/nixpkgs/tree/8616af08d915377bd930395f3b700a0e93d08728/maintainers/scripts/auto-rebase). If you run into any problems regarding any of this, please reach out to the [formatting team](https://nixos.org/community/teams/formatting/) by pinging @NixOS/nix-formatting.
2025-04-01 20:10:43 +02:00
firefox: add profile-guided optimization Lo and behold, we're finally catching up with Mozillas very own firefox build in terms of speed. PGO is an optimization technique in which in a first step we create a build that supports instrumentation, meaning we can use it to create a profile of how the browser behaved during usage. Then in a second pass we create the final build that uses the acquired profiling data to optimize the browser for the workload it actually received during profiling. The downside is that with PGO we now need to build Firefox twice, which increases the build time from around 20 minutes to roughly 50 minutes. In the Speedometer 2.0 benchmark multiple tests could see a responsiveness improvemeant around 20-25%, which makes the increased build time well worth it. Sadly this benefit seems limited to x86_64-linux, builds on aarch64-linux get stuck during profiling and I haven't found out why. Finally, after a long time, we can say: Closes: #76484 Supersedes: #129503
2022-03-22 03:35:51 +01:00
# Don't try to send libnotify notifications during build
export MOZ_NOSPAM=1
treewide: Format all Nix files Format all Nix files using the officially approved formatter, making the CI check introduced in the previous commit succeed: nix-build ci -A fmt.check This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153) of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166). This commit will lead to merge conflicts for a number of PRs, up to an estimated ~1100 (~33%) among the PRs with activity in the past 2 months, but that should be lower than what it would be without the previous [partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537). Merge conflicts caused by this commit can now automatically be resolved while rebasing using the [auto-rebase script](https://github.com/NixOS/nixpkgs/tree/8616af08d915377bd930395f3b700a0e93d08728/maintainers/scripts/auto-rebase). If you run into any problems regarding any of this, please reach out to the [formatting team](https://nixos.org/community/teams/formatting/) by pinging @NixOS/nix-formatting.
2025-04-01 20:10:43 +02:00
firefox: set consistent remoting name With Firefox 98.0 the remoting name now depends on the update channel (mozbz#1752418), which resulted in a weird app_id/wmclass of `firefox-default`, which broke window association in GNOME and likely other desktops. Fixes: #165107
2022-03-21 15:20:36 +01:00
# Set consistent remoting name to ensure wmclass matches with desktop file
export MOZ_APP_REMOTINGNAME="${binaryName}"
treewide: Format all Nix files Format all Nix files using the officially approved formatter, making the CI check introduced in the previous commit succeed: nix-build ci -A fmt.check This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153) of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166). This commit will lead to merge conflicts for a number of PRs, up to an estimated ~1100 (~33%) among the PRs with activity in the past 2 months, but that should be lower than what it would be without the previous [partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537). Merge conflicts caused by this commit can now automatically be resolved while rebasing using the [auto-rebase script](https://github.com/NixOS/nixpkgs/tree/8616af08d915377bd930395f3b700a0e93d08728/maintainers/scripts/auto-rebase). If you run into any problems regarding any of this, please reach out to the [formatting team](https://nixos.org/community/teams/formatting/) by pinging @NixOS/nix-formatting.
2025-04-01 20:10:43 +02:00
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
# AS=as in the environment causes build failure
# https://bugzilla.mozilla.org/show_bug.cgi?id=1497286
unset AS
treewide: Format all Nix files Format all Nix files using the officially approved formatter, making the CI check introduced in the previous commit succeed: nix-build ci -A fmt.check This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153) of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166). This commit will lead to merge conflicts for a number of PRs, up to an estimated ~1100 (~33%) among the PRs with activity in the past 2 months, but that should be lower than what it would be without the previous [partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537). Merge conflicts caused by this commit can now automatically be resolved while rebasing using the [auto-rebase script](https://github.com/NixOS/nixpkgs/tree/8616af08d915377bd930395f3b700a0e93d08728/maintainers/scripts/auto-rebase). If you run into any problems regarding any of this, please reach out to the [formatting team](https://nixos.org/community/teams/formatting/) by pinging @NixOS/nix-formatting.
2025-04-01 20:10:43 +02:00
buildMozillaMach: Update native python env var With Firefox 100.0 the following deprecation warning comes up: > The "MACH_USE_SYSTEM_PYTHON" environment variable is deprecated, > please unset it or replace it with either > "MACH_BUILD_PYTHON_NATIVE_PACKAGE_SOURCE=system" or > "MACH_BUILD_PYTHON_NATIVE_PACKAGE_SOURCE=none" And since we want to continue using our own python we're going for the system value when the version is at least 100.0.
2022-05-12 15:16:44 +02:00
# Use our own python
export MACH_BUILD_PYTHON_NATIVE_PACKAGE_SOURCE=system
treewide: Format all Nix files Format all Nix files using the officially approved formatter, making the CI check introduced in the previous commit succeed: nix-build ci -A fmt.check This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153) of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166). This commit will lead to merge conflicts for a number of PRs, up to an estimated ~1100 (~33%) among the PRs with activity in the past 2 months, but that should be lower than what it would be without the previous [partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537). Merge conflicts caused by this commit can now automatically be resolved while rebasing using the [auto-rebase script](https://github.com/NixOS/nixpkgs/tree/8616af08d915377bd930395f3b700a0e93d08728/maintainers/scripts/auto-rebase). If you run into any problems regarding any of this, please reach out to the [formatting team](https://nixos.org/community/teams/formatting/) by pinging @NixOS/nix-formatting.
2025-04-01 20:10:43 +02:00
firefox: enable RLBox sandboxing https://hacks.mozilla.org/2021/12/webassembly-and-back-again-fine-grained-sandboxing-in-firefox-95/ Co-authored-by: Jörg Thalheim <joerg@thalheim.io>
2022-03-09 19:40:08 +01:00
# RBox WASM Sandboxing
export WASM_CC=${pkgsCross.wasi32.stdenv.cc}/bin/${pkgsCross.wasi32.stdenv.cc.targetPrefix}cc
export WASM_CXX=${pkgsCross.wasi32.stdenv.cc}/bin/${pkgsCross.wasi32.stdenv.cc.targetPrefix}c++
firefox: fix indentation
2023-04-26 15:18:38 +02:00
''
+ lib.optionalString pgoSupport ''
if [ -e "$TMPDIR/merged.profdata" ]; then
echo "Configuring with profiling data"
for i in "''${!configureFlagsArray[@]}"; do
if [[ ''${configureFlagsArray[i]} = "--enable-profile-generate=cross" ]]; then
unset 'configureFlagsArray[i]'
fi
done
buildMozillaMach: fix pgo configure flags This broke when support for opt-in __structuredAttrs was added in 238a6053. Fixes: #283563
2024-01-28 03:01:45 +01:00
appendToVar configureFlags --enable-profile-use=cross
appendToVar configureFlags --with-pgo-profile-path=$TMPDIR/merged.profdata
appendToVar configureFlags --with-pgo-jarlog=$TMPDIR/jarlog
firefox: fix indentation
2023-04-26 15:18:38 +02:00
${lib.optionalString stdenv.hostPlatform.isMusl ''
LDFLAGS="$OLD_LDFLAGS"
unset OLD_LDFLAGS
''}
else
echo "Configuring to generate profiling data"
configureFlagsArray+=(
"--enable-profile-generate=cross"
)
${lib.optionalString stdenv.hostPlatform.isMusl
# Set the rpath appropriately for the profiling run
# During the profiling run, loading libraries from $out would fail,
# since the profiling build has not been installed to $out
''
OLD_LDFLAGS="$LDFLAGS"
buildMozillaMach: stop polluting the hg tree Moves the MOZ_OBJDIR into a path that is ignored through .hgignore, and the MOZBUILD_STATE_PATH outside of the source root. Closes: #306937
2024-04-28 16:13:25 +02:00
LDFLAGS="-Wl,-rpath,$(pwd)/objdir/dist/${binaryName}"
firefox: fix indentation
2023-04-26 15:18:38 +02:00
''
}
fi
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
''
firefox: disable 'MOZILLA_OFFICIAL=1' on i686 Without the change firefox build on i686 fails at configure time: $ NIXPKGS_ALLOW_BROKEN=1 nix build -f. --argstr system "i686-linux" firefox ... mozbuild.configure.options.InvalidOptionError: '--enable-release' implied by 'MOZILLA_OFFICIAL' conflicts with '--disable-release' from the command-line The change uses the same 32-bit guard for both. It still does not allow i686 build to succeed for other toolchain misconfiguration, but it's a step forward.
2022-05-29 07:28:42 +01:00
+ lib.optionalString (enableOfficialBranding && !stdenv.hostPlatform.is32bit) ''
firefox: fix enableOfficialBranding
2021-08-11 20:14:23 -04:00
export MOZILLA_OFFICIAL=1
buildMozillaMach: support disabling extension signing enforcement Previously, derivations specified the environment variable themselves, which did not actually disable signing enforcement.
2023-07-20 19:13:51 -04:00
''
+ lib.optionalString (!requireSigning) ''
export MOZ_REQUIRE_SIGNING=
pkgsMusl.firefox: fix build
2022-08-15 11:50:26 +02:00
''
+ lib.optionalString stdenv.hostPlatform.isMusl ''
# linking firefox hits the vm.max_map_count kernel limit with the default musl allocator
nixos/sysctl: raise default vm.max_map_count to 1048576
2023-06-21 19:23:08 +02:00
# TODO: Default vm.max_map_count has been increased, retest without this
pkgsMusl.firefox: fix build
2022-08-15 11:50:26 +02:00
export LD_PRELOAD=${mimalloc}/lib/libmimalloc.so
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
'';
firefox: refactor into firefoxPackages, add more options
2017-03-27 12:33:00 +00:00
firefox-unwrapped: fix cross compilation
2022-05-03 10:23:35 +08:00
# firefox has a different definition of configurePlatforms from nixpkgs, see configureFlags
configurePlatforms = [ ];
firefox: refactor into firefoxPackages, add more options
2017-03-27 12:33:00 +00:00
configureFlags =
[
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
"--disable-tests"
"--disable-updater"
firefox: rename some attributes in packaging This should not change the derivation, but the new attribute names make more sense once we package something that is not Firefox using this expression.
2021-07-13 19:04:57 +02:00
"--enable-application=${application}"
firefox: enable darwin builds
2024-10-20 22:55:34 -04:00
"--enable-default-toolkit=${toolkit}"
firefox-{beta,devedition}: make binaryName match desktop file This branches off of the unmerged PR #294971, which had the goal of distinguishing between the various Firefox packages by giving them all unique binaryNames. The goal of this PR, by contrast, is making the names of the XDG desktop files that we generate match the name by which Firefox will identify itself over D-Bus. Co-authored-by: Xandor Schiefer <me@xandor.co.za>
2025-01-05 21:27:45 -05:00
"--with-app-name=${binaryName}"
buildMozillaMach: Add distribution identifier and distribution.ini Adds a distribution id useful for aggregation of crash statistics. Also creates a NixOS flavor, visible through the About window, that is also exposed through telemetry data, if enabled.
2022-05-16 00:26:57 +02:00
"--with-distribution-id=org.nixos"
treewide: use getLib when accessing clang / libclang / stdenv.cc.cc In preparation to eliminate the lib output for the unwrapped clang, use `lib.getLib` to access the `lib` output.
2024-11-07 09:43:39 +00:00
"--with-libclang-path=${lib.getLib llvmPackagesBuildBuild.libclang}/lib"
buildMozillaMach: Cleanup obsolete version gates
2022-12-03 22:39:23 +01:00
"--with-wasi-sysroot=${wasiSysRoot}"
firefox-unwrapped: fix cross compilation
2022-05-03 10:23:35 +08:00
# for firefox, host is buildPlatform, target is hostPlatform
"--host=${buildStdenv.buildPlatform.config}"
"--target=${buildStdenv.hostPlatform.config}"
firefoxPackages: tor-browser: init at 6.5.2
2017-04-01 00:00:00 +00:00
]
firefox: let LTO on Darwin select its own linker
2020-10-08 21:55:23 -04:00
# LTO is done using clang and lld on Linux.
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
++ lib.optionals ltoSupport [
firefox: extend compile flag "--enable-lto=cross" with parameter "full" This fixes a regression in the discord web app. The issue was reported in: https://github.com/NixOS/nixpkgs/issues/332540 The regression was introduced in commit 23d4f834 via an upgrade of rust compiler from 1.77.2 to 1.78.0. The fix is based on a comparison between the generated firefox build script generated by pkgs/applications/networking/browsers/firefox/common.nix and the firefox build script of archlinux found at: https://gitlab.archlinux.org/archlinux/packaging/packages/firefox/-/blob/1376cddc7e29fe049fd4afc15fc3b7da5e5fc99b/PKGBUILD Enabling "full" link time optimization fixed the regression in the discord web app. Further compile flags where not ported from the archlinux build script.
2024-12-20 19:32:30 +01:00
"--enable-lto=cross,full" # Cross-Language LTO
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
"--enable-linker=lld"
]
buildMozillaMach: re-enable elf-hack with LTO/LLD, disable with musl (#365185) The elfhack was completely revamped and is now implemented with the "relrhack", which is compatible with LLD: https://glandium.org/blog/?p=4297 Exposes a new option elfhackSupport and sets reasonable default based on the properties of the new relrhack. Change-Id: I687d4ee68a8e836e5c51a1fde0d28d019c0c66b9
2024-12-14 20:10:17 +01:00
++ lib.optional (isElfhackPlatform stdenv) (enableFeature elfhackSupport "elf-hack")
firefox: fix drmSupport flag In #109133 @alyssais discovered that the drmSupport flag stopped working. This is because Mozilla decided around Firefox 51 (mozbz#1289634) to swap the default values and our flag was asking for the wrong thing all along. Since this flag has now been enabled for multiple years, disabling it would mean a regression for our users. Leaving it enabled should be unproblematic since it only controls whether Firefox shows the EME nagbar, that allows to enable Widevine CDM, when a site requests it. The choice is therefore completely up to the enduser. Disabling this nagbar is still possible at runtime by setting `browser.eme.ui.enabled` to `false`. If Widevine CDM was inadvertently enabled it can be disabled at `media.gmp-widevinecdm.enabled`. Supersedes: #109133
2022-03-28 15:26:04 +02:00
++ lib.optional (!drmSupport) "--disable-eme"
buildMozillaMach: cleanup
2025-05-12 03:49:16 +02:00
++ lib.optional allowAddonSideload "--allow-addon-sideload"
firefox: enable darwin builds
2024-10-20 22:55:34 -04:00
++ lib.optionals (!stdenv.hostPlatform.isDarwin) [
# MacOS builds use bundled versions of libraries: https://bugzilla.mozilla.org/show_bug.cgi?id=1776255
"--enable-system-pixman"
"--with-system-ffi"
buildMozillaMach: reenable system-icu By appling a patch from chaotic-nyx linking against icu76 and newer works again. From Firefox 139 upstream uses icu77, but it already works today on 138.0.1. https://bugzilla.mozilla.org/show_bug.cgi?id=1927380
2025-05-12 03:49:34 +02:00
"--with-system-icu"
firefox: enable darwin builds
2024-10-20 22:55:34 -04:00
"--with-system-jpeg"
"--with-system-libevent"
"--with-system-libvpx"
"--with-system-nspr"
"--with-system-nss"
"--with-system-png" # needs APNG support
"--with-system-webp"
"--with-system-zlib"
treewide: Format all Nix files Format all Nix files using the officially approved formatter, making the CI check introduced in the previous commit succeed: nix-build ci -A fmt.check This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153) of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166). This commit will lead to merge conflicts for a number of PRs, up to an estimated ~1100 (~33%) among the PRs with activity in the past 2 months, but that should be lower than what it would be without the previous [partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537). Merge conflicts caused by this commit can now automatically be resolved while rebasing using the [auto-rebase script](https://github.com/NixOS/nixpkgs/tree/8616af08d915377bd930395f3b700a0e93d08728/maintainers/scripts/auto-rebase). If you run into any problems regarding any of this, please reach out to the [formatting team](https://nixos.org/community/teams/formatting/) by pinging @NixOS/nix-formatting.
2025-04-01 20:10:43 +02:00
firefox: enable darwin builds
2024-10-20 22:55:34 -04:00
# These options are not available on MacOS, even --disable-*
buildMozillaMach: use enableFeature instead of recreating it
2022-11-24 15:56:43 -03:00
(enableFeature alsaSupport "alsa")
firefox: enable darwin builds
2024-10-20 22:55:34 -04:00
(enableFeature jackSupport "jack")
(enableFeature pulseaudioSupport "pulseaudio")
(enableFeature sndioSupport "sndio")
]
++ [
buildMozillaMach: use enableFeature instead of recreating it
2022-11-24 15:56:43 -03:00
(enableFeature crashreporterSupport "crashreporter")
(enableFeature ffmpegSupport "ffmpeg")
(enableFeature geolocationSupport "necko-wifi")
(enableFeature gssSupport "negotiateauth")
(enableFeature jemallocSupport "jemalloc")
(enableFeature webrtcSupport "webrtc")
treewide: Format all Nix files Format all Nix files using the officially approved formatter, making the CI check introduced in the previous commit succeed: nix-build ci -A fmt.check This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153) of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166). This commit will lead to merge conflicts for a number of PRs, up to an estimated ~1100 (~33%) among the PRs with activity in the past 2 months, but that should be lower than what it would be without the previous [partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537). Merge conflicts caused by this commit can now automatically be resolved while rebasing using the [auto-rebase script](https://github.com/NixOS/nixpkgs/tree/8616af08d915377bd930395f3b700a0e93d08728/maintainers/scripts/auto-rebase). If you run into any problems regarding any of this, please reach out to the [formatting team](https://nixos.org/community/teams/formatting/) by pinging @NixOS/nix-formatting.
2025-04-01 20:10:43 +02:00
buildMozillaMach: use enableFeature instead of recreating it
2022-11-24 15:56:43 -03:00
(enableFeature debugBuild "debug")
(if debugBuild then "--enable-profiling" else "--enable-optimize")
# --enable-release adds -ffunction-sections & LTO that require a big amount
# of RAM, and the 32-bit memory space cannot handle that linking
(enableFeature (!debugBuild && !stdenv.hostPlatform.is32bit) "release")
(enableFeature enableDebugSymbols "debug-symbols")
]
firefox: enable separated debug symbols
2021-11-16 18:38:56 +08:00
++ lib.optionals enableDebugSymbols [
"--disable-strip"
"--disable-install-strip"
]
firefox-devedition-unwrapped: fix branding
2025-03-13 22:16:28 -04:00
# As of Firefox 137 (https://bugzilla.mozilla.org/show_bug.cgi?id=1943009),
# the --enable-official-branding flag overrides the --with-branding flag.
++ lib.optional (enableOfficialBranding && branding == null) "--enable-official-branding"
buildMozillaMach: add branding option to change the path where the branding is located
2023-03-23 17:47:51 +01:00
++ lib.optional (branding != null) "--with-branding=${branding}"
firefoxPackages: add `extraConfigureFlags` to common builder, move `--disable-loop` flag to tor-browser expression
2017-08-15 00:00:00 +00:00
++ extraConfigureFlags;
treewide: Format all Nix files Format all Nix files using the officially approved formatter, making the CI check introduced in the previous commit succeed: nix-build ci -A fmt.check This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153) of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166). This commit will lead to merge conflicts for a number of PRs, up to an estimated ~1100 (~33%) among the PRs with activity in the past 2 months, but that should be lower than what it would be without the previous [partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537). Merge conflicts caused by this commit can now automatically be resolved while rebasing using the [auto-rebase script](https://github.com/NixOS/nixpkgs/tree/8616af08d915377bd930395f3b700a0e93d08728/maintainers/scripts/auto-rebase). If you run into any problems regarding any of this, please reach out to the [formatting team](https://nixos.org/community/teams/formatting/) by pinging @NixOS/nix-formatting.
2025-04-01 20:10:43 +02:00
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
buildInputs =
[
bzip2
firefox: enable darwin builds
2024-10-20 22:55:34 -04:00
file
libGL
libGLU
libstartup_notification
perl
zip
]
++ lib.optionals stdenv.hostPlatform.isDarwin [
buildMozillaMach: apple-sdk_14 -> apple-sdk_15 starting with version 138 0:01.18 ERROR: SDK version "14.4" is too old. Please upgrade to at least 15.2. Try updating your system Xcode. Newer versions of firefox require apple-sdk_15.
2025-04-19 15:08:02 -05:00
(if lib.versionAtLeast version "138" then apple-sdk_15 else apple-sdk_14)
firefox: enable darwin builds
2024-10-20 22:55:34 -04:00
cups
]
++ (lib.optionals (!stdenv.hostPlatform.isDarwin) (
[
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
dbus
dbus-glib
fontconfig
freetype
glib
gtk3
libffi
libevent
libjpeg
libpng
libvpx
libwebp
nspr
pango
xorg.libX11
xorg.libXcursor
xorg.libXdamage
xorg.libXext
xorg.libXft
xorg.libXi
xorg.libXrender
xorg.libXt
xorg.libXtst
xorg.pixman
xorg.xorgproto
zlib
firefox: enable darwin builds
2024-10-20 22:55:34 -04:00
(
buildMozillaMach: update nss version range While building Firefox ESR with the latest NSS version generally works we and upstream actually prefer using the ESR versions together.
2025-05-12 03:51:57 +02:00
if (lib.versionAtLeast version "129") then nss_latest else nss_esr # 3.90
firefox: enable darwin builds
2024-10-20 22:55:34 -04:00
)
]
++ lib.optional alsaSupport alsa-lib
++ lib.optional jackSupport libjack2
++ lib.optional pulseaudioSupport libpulseaudio # only headers are needed
++ lib.optional sndioSupport sndio
++ lib.optionals waylandSupport [
libxkbcommon
libdrm
]
))
buildMozillaMach: reenable system-icu By appling a patch from chaotic-nyx linking against icu76 and newer works again. From Firefox 139 upstream uses icu77, but it already works today on 138.0.1. https://bugzilla.mozilla.org/show_bug.cgi?id=1927380
2025-05-12 03:49:34 +02:00
++ [ (if (lib.versionAtLeast version "138") then icu77 else icu73) ]
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
++ lib.optional gssSupport libkrb5
++ lib.optional jemallocSupport jemalloc
++ extraBuildInputs;
firefox: add profile-guided optimization Lo and behold, we're finally catching up with Mozillas very own firefox build in terms of speed. PGO is an optimization technique in which in a first step we create a build that supports instrumentation, meaning we can use it to create a profile of how the browser behaved during usage. Then in a second pass we create the final build that uses the acquired profiling data to optimize the browser for the workload it actually received during profiling. The downside is that with PGO we now need to build Firefox twice, which increases the build time from around 20 minutes to roughly 50 minutes. In the Speedometer 2.0 benchmark multiple tests could see a responsiveness improvemeant around 20-25%, which makes the increased build time well worth it. Sadly this benefit seems limited to x86_64-linux, builds on aarch64-linux get stuck during profiling and I haven't found out why. Finally, after a long time, we can say: Closes: #76484 Supersedes: #129503
2022-03-22 03:35:51 +01:00
profilingPhase = lib.optionalString pgoSupport ''
# Package up Firefox for profiling
./mach package
# Run profiling
(
export HOME=$TMPDIR
export LLVM_PROFDATA=llvm-profdata
export JARLOG_FILE="$TMPDIR/jarlog"
xvfb-run -w 10 -s "-screen 0 1920x1080x24" \
./mach python ./build/pgo/profileserver.py
)
# Copy profiling data to a place we can easily reference
cp ./merged.profdata $TMPDIR/merged.profdata
# Clean build dir
./mach clobber
'';
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
preBuild = ''
buildMozillaMach: stop polluting the hg tree Moves the MOZ_OBJDIR into a path that is ignored through .hgignore, and the MOZBUILD_STATE_PATH outside of the source root. Closes: #306937
2024-04-28 16:13:25 +02:00
cd objdir
firefox: common: cleanup configure phase
2018-02-01 00:00:00 +00:00
'';
firefox: add profile-guided optimization Lo and behold, we're finally catching up with Mozillas very own firefox build in terms of speed. PGO is an optimization technique in which in a first step we create a build that supports instrumentation, meaning we can use it to create a profile of how the browser behaved during usage. Then in a second pass we create the final build that uses the acquired profiling data to optimize the browser for the workload it actually received during profiling. The downside is that with PGO we now need to build Firefox twice, which increases the build time from around 20 minutes to roughly 50 minutes. In the Speedometer 2.0 benchmark multiple tests could see a responsiveness improvemeant around 20-25%, which makes the increased build time well worth it. Sadly this benefit seems limited to x86_64-linux, builds on aarch64-linux get stuck during profiling and I haven't found out why. Finally, after a long time, we can say: Closes: #76484 Supersedes: #129503
2022-03-22 03:35:51 +01:00
postBuild = ''
cd ..
'';
firefox: remove unnecessary make flags and LD_FLAGS Since we are using LLVM stdenv when enabling LTO, there are no need to manually specify them.
2021-11-16 18:40:02 +08:00
makeFlags = extraMakeFlags;
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
separateDebugInfo = enableDebugSymbols;
firefox: Build without xulrunner Fixes #2950.
2014-07-23 15:31:49 +02:00
enableParallelBuilding = true;
pkgsMusl.firefox: fix build
2022-08-15 11:50:26 +02:00
env = lib.optionalAttrs stdenv.hostPlatform.isMusl {
# Firefox relies on nonstandard behavior of the glibc dynamic linker. It re-uses
# previously loaded libraries even though they are not in the rpath of the newly loaded binary.
treewide: fix typos in comments Made with ```shell git restore . fd '\.nix$' pkgs/ --type f -j1 -x bash -xc "$(cat <<"EOF" typos --no-check-filenames --write-changes "$1" git diff --exit-code "$1" && exit #( git diff "$1" | grep -qE "^\+ +[^# ]") && git restore "$1" count1="$( bat --language nix --diff --style changes "$1" --theme "Monokai Extended" --color always | aha --no-header | grep -E '^<span style="color:olive;">~</span> ' | wc -l )" count2="$( bat --language nix --diff --style changes "$1" --theme "Monokai Extended" --color always | aha --no-header | grep -E '^<span style="color:olive;">~</span> (<span style="color:#f8f8f2;"> *</span>)?<span style="color:#75715e;">.*</span>$' | wc -l )" [[ $count1 -ne $count2 ]] && git restore "$1" EOF )" -- {} ``` and filtered with `GIT_DIFF_OPTS='--unified=15' git -c interactive.singleKey=true add --patch` I initially tried using the tree-sitter cli, python bindings and even ast-grep through various means, but this is what I ended up with.
2025-02-22 21:23:34 +01:00
# On musl we have to explicitly set the rpath to include these libraries.
pkgsMusl.firefox: fix build
2022-08-15 11:50:26 +02:00
LDFLAGS = "-Wl,-rpath,${placeholder "out"}/lib/${binaryName}";
};
firefox: reformat, sort, cleanup It is normal for such a large derivation to accumulate mixed codestyles over all those years making it harder to maintain. By splitting up dependencies to one per line I noticed two unused dependencies (hunspell, sqlite) that were removed in this change. Also most lists are now sorted alphabetically, so reasoning about them has become much easier. Lists now use the same style for indentation and concat, and environment variables are all defined in preConfigure as opposed to bare in the derivation. The object dir, firefox build directory, is now in a predictable directory at ${pwd}/mozobj as opposed to ${pwd}/obj-@CONFIG_GUESS@, saving us one wildcard expansion. This is also a good prepration for the PGO build where we need to reference bits inside this directory. Added a few comments and clarified others from what I've learned how the firefox build works.
2022-03-21 20:09:59 +01:00
# tests were disabled in configureFlags
doCheck = false;
firefox: Build without xulrunner Fixes #2950.
2014-07-23 15:31:49 +02:00
buildMozillaMach: create symbols output Thie zip bundle in this output is used in the dumps sent by the crashreporter. For this to happen we need to upload this zip file to https://symbols.mozilla.org, which is a separate effort.
2022-05-12 14:40:21 +02:00
# Generate build symbols once after the final build
# https://firefox-source-docs.mozilla.org/crash-reporting/uploading_symbol.html
buildMozillaMach: fix builds with crash reporting disabled - only try to build and copy crash reporting symbols when crash reporting is enabled - fixes the librewolf build
2022-05-16 13:52:15 -07:00
preInstall =
lib.optionalString crashreporterSupport ''
buildMozillaMach: create symbols output Thie zip bundle in this output is used in the dumps sent by the crashreporter. For this to happen we need to upload this zip file to https://symbols.mozilla.org, which is a separate effort.
2022-05-12 14:40:21 +02:00
./mach buildsymbols
mkdir -p $symbols/
buildMozillaMach: stop polluting the hg tree Moves the MOZ_OBJDIR into a path that is ignored through .hgignore, and the MOZBUILD_STATE_PATH outside of the source root. Closes: #306937
2024-04-28 16:13:25 +02:00
cp objdir/dist/*.crashreporter-symbols.zip $symbols/
buildMozillaMach: fix builds with crash reporting disabled - only try to build and copy crash reporting symbols when crash reporting is enabled - fixes the librewolf build
2022-05-16 13:52:15 -07:00
''
+ ''
buildMozillaMach: stop polluting the hg tree Moves the MOZ_OBJDIR into a path that is ignored through .hgignore, and the MOZBUILD_STATE_PATH outside of the source root. Closes: #306937
2024-04-28 16:13:25 +02:00
cd objdir
firefox: add profile-guided optimization Lo and behold, we're finally catching up with Mozillas very own firefox build in terms of speed. PGO is an optimization technique in which in a first step we create a build that supports instrumentation, meaning we can use it to create a profile of how the browser behaved during usage. Then in a second pass we create the final build that uses the acquired profiling data to optimize the browser for the workload it actually received during profiling. The downside is that with PGO we now need to build Firefox twice, which increases the build time from around 20 minutes to roughly 50 minutes. In the Speedometer 2.0 benchmark multiple tests could see a responsiveness improvemeant around 20-25%, which makes the increased build time well worth it. Sadly this benefit seems limited to x86_64-linux, builds on aarch64-linux get stuck during profiling and I haven't found out why. Finally, after a long time, we can say: Closes: #76484 Supersedes: #129503
2022-03-22 03:35:51 +01:00
'';
firefox: enable darwin builds
2024-10-20 22:55:34 -04:00
# The target will prepare .app bundle
installTargets = lib.optionalString stdenv.hostPlatform.isDarwin "stage-package";
postInstall =
lib.optionalString stdenv.hostPlatform.isDarwin ''
mkdir -p $out/Applications
firefox, thunderbird: enable wrapped derivations for darwin It also aligns application names for wrapped and unwrapped flavors of the same derivations; and uses unique application names for each flavor, so it's now possible to install multiple versions on the same Darwin machine. One visible change now is that `About Firefox` window now shows: `Firefox for NixOS` instead of `Mozilla Firefox for NixOS` ...in the `distribution` field. I think it's fine and doesn't infringe on any trademarks because this field is not required to mention Mozilla at all, as per: https://wiki.mozilla.org/Distribution_INI_File While at it, also changed the branding for Darwin builds to list: `Firefox for Nix on MacOS` instead of `Firefox for NixOS` The telemetry and distribution ids (`nixos`) are left intact. Note: it's still not possible to install both source-based and -bin Darwin derivations in the same profile. It would require renaming applicationNames for these two different types to use unique names (e.g. `Firefox (Official)` or `Firefox (Binary)`, which doesn't seem optimal. Closes: #378433 Closes: #366581 Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
2025-01-29 20:35:46 -05:00
cp -r dist/${binaryName}/*.app "$out/Applications/${applicationName}.app"
buildMozillaMach: Add distribution identifier and distribution.ini Adds a distribution id useful for aggregation of crash statistics. Also creates a NixOS flavor, visible through the About window, that is also exposed through telemetry data, if enabled.
2022-05-16 00:26:57 +02:00
firefox, thunderbird: enable wrapped derivations for darwin It also aligns application names for wrapped and unwrapped flavors of the same derivations; and uses unique application names for each flavor, so it's now possible to install multiple versions on the same Darwin machine. One visible change now is that `About Firefox` window now shows: `Firefox for NixOS` instead of `Mozilla Firefox for NixOS` ...in the `distribution` field. I think it's fine and doesn't infringe on any trademarks because this field is not required to mention Mozilla at all, as per: https://wiki.mozilla.org/Distribution_INI_File While at it, also changed the branding for Darwin builds to list: `Firefox for Nix on MacOS` instead of `Firefox for NixOS` The telemetry and distribution ids (`nixos`) are left intact. Note: it's still not possible to install both source-based and -bin Darwin derivations in the same profile. It would require renaming applicationNames for these two different types to use unique names (e.g. `Firefox (Official)` or `Firefox (Binary)`, which doesn't seem optimal. Closes: #378433 Closes: #366581 Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
2025-01-29 20:35:46 -05:00
resourceDir="$out/Applications/${applicationName}.app/Contents/Resources"
firefox: enable darwin builds
2024-10-20 22:55:34 -04:00
''
+ lib.optionalString (!stdenv.hostPlatform.isDarwin) ''
firefox: refactor into firefoxPackages, add more options
2017-03-27 12:33:00 +00:00
# Remove SDK cruft. FIXME: move to a separate output?
firefoxPackages.icecat: init at 60.3.0, 52.6.0 It works, but this state is far from ideal: GNU guys update generated source tarballs very infrequently. Ideally, src needs to be generated by running makeicecat over firefox src. Will do later.
2019-01-01 00:00:00 +00:00
rm -rf $out/share/idl $out/include $out/lib/${binaryName}-devel-*
firefox: refactor into firefoxPackages, add more options
2017-03-27 12:33:00 +00:00
# Needed to find Mozilla runtime
firefoxPackages.icecat: init at 60.3.0, 52.6.0 It works, but this state is far from ideal: GNU guys update generated source tarballs very infrequently. Ideally, src needs to be generated by running makeicecat over firefox src. Will do later.
2019-01-01 00:00:00 +00:00
gappsWrapperArgs+=(--argv0 "$out/bin/.${binaryName}-wrapped")
firefox: enable darwin builds
2024-10-20 22:55:34 -04:00
resourceDir=$out/lib/${binaryName}
''
+ ''
# Install distribution customizations
install -Dvm644 ${distributionIni} "$resourceDir/distribution/distribution.ini"
install -Dvm644 ${defaultPrefsFile} "$resourceDir/browser/defaults/preferences/nixos-default-prefs.js"
cd ..
firefox: refactor into firefoxPackages, add more options
2017-03-27 12:33:00 +00:00
'';
firefox: enable darwin builds
2024-10-20 22:55:34 -04:00
postFixup = lib.optionalString (crashreporterSupport && buildStdenv.hostPlatform.isLinux) ''
buildMozillaMach: add curl into crashreporter rpath Firefox has been crashy during the 106 cycle on my laptop, so I saw the crashreporter more often than not. In the terminal spew I found > Failed to open curl lib from binary, use libcurl.so instead and the GUI told me submitting the report had failed. Not great if you actually except to have your bugs fixed at some point.
2022-11-08 00:02:25 +01:00
patchelf --add-rpath "${lib.makeLibraryPath [ curl ]}" $out/lib/${binaryName}/crashreporter
'';
firefox: enable darwin builds
2024-10-20 22:55:34 -04:00
# Some basic testing
firefox: misc cleanups Move more dependencies to nativeBuildInputs. Use wrapGAppsHook. Add checkInstallPhase.
2017-04-09 20:17:40 +03:00
doInstallCheck = true;
firefox: enable darwin builds
2024-10-20 22:55:34 -04:00
installCheckPhase =
lib.optionalString buildStdenv.hostPlatform.isDarwin ''
firefox, thunderbird: enable wrapped derivations for darwin It also aligns application names for wrapped and unwrapped flavors of the same derivations; and uses unique application names for each flavor, so it's now possible to install multiple versions on the same Darwin machine. One visible change now is that `About Firefox` window now shows: `Firefox for NixOS` instead of `Mozilla Firefox for NixOS` ...in the `distribution` field. I think it's fine and doesn't infringe on any trademarks because this field is not required to mention Mozilla at all, as per: https://wiki.mozilla.org/Distribution_INI_File While at it, also changed the branding for Darwin builds to list: `Firefox for Nix on MacOS` instead of `Firefox for NixOS` The telemetry and distribution ids (`nixos`) are left intact. Note: it's still not possible to install both source-based and -bin Darwin derivations in the same profile. It would require renaming applicationNames for these two different types to use unique names (e.g. `Firefox (Official)` or `Firefox (Binary)`, which doesn't seem optimal. Closes: #378433 Closes: #366581 Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
2025-01-29 20:35:46 -05:00
bindir="$out/Applications/${applicationName}.app/Contents/MacOS"
firefox: enable darwin builds
2024-10-20 22:55:34 -04:00
''
+ lib.optionalString (!buildStdenv.hostPlatform.isDarwin) ''
bindir=$out/bin
''
+ ''
"$bindir/${binaryName}" --version
firefox: refactor into firefoxPackages, add more options
2017-03-27 12:33:00 +00:00
'';
firefox: Update to 21.0 Only problem was that the chrome resources were not in the right place (and you only see that by running with the -jsconsole flag).
2013-06-06 13:07:54 +02:00
firefox: Build without xulrunner Fixes #2950.
2014-07-23 15:31:49 +02:00
passthru = {
firefox, thunderbird: enable wrapped derivations for darwin It also aligns application names for wrapped and unwrapped flavors of the same derivations; and uses unique application names for each flavor, so it's now possible to install multiple versions on the same Darwin machine. One visible change now is that `About Firefox` window now shows: `Firefox for NixOS` instead of `Mozilla Firefox for NixOS` ...in the `distribution` field. I think it's fine and doesn't infringe on any trademarks because this field is not required to mention Mozilla at all, as per: https://wiki.mozilla.org/Distribution_INI_File While at it, also changed the branding for Darwin builds to list: `Firefox for Nix on MacOS` instead of `Firefox for NixOS` The telemetry and distribution ids (`nixos`) are left intact. Note: it's still not possible to install both source-based and -bin Darwin derivations in the same profile. It would require renaming applicationNames for these two different types to use unique names (e.g. `Firefox (Official)` or `Firefox (Binary)`, which doesn't seem optimal. Closes: #378433 Closes: #366581 Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
2025-01-29 20:35:46 -05:00
inherit applicationName;
buildMozillaMach: passthru application, extraPatches to be later used by betterbird package
2023-02-24 11:46:48 +01:00
inherit application extraPatches;
firefox: simplify derivation with firefox 64 being the latest version, and the removal of "tor-browser/icecat-like" variants, we can greatly simplify the common firefox derivation.
2020-02-01 18:56:13 +01:00
inherit updateScript;
firefox: place alsaLib in lib search patch libcubeb has dlopened libraries for awhile now. In nixpkgs there was support for the PulseAudio backend doing this, however the ALSA backend support was missed and caused issue #79310 (no sound with ALSA). This gives ALSA users the ability to hear sound once again.
2020-10-21 21:47:30 -04:00
inherit alsaSupport;
firefox: drop darwin support Darwin support was marked broken in 2019 with Firefox 69 and has missed therefore missed out and not been tested on the following 29 major releases since. It cannot be supported again without a darwin user stepping up to take care and work on and test every major release, which hasn't happened since I took over maintainership. The recommendation of the people that tend to the firefox source build is for darwin users to use firefox-bin instead.
2022-03-21 16:03:59 +01:00
inherit binaryName;
buildMozillaMach: passthru requireSigning/allowAddonSideload Fixes wrapper-installed addons, which previously rejected valid browser configurations
2023-11-25 01:53:53 -05:00
inherit requireSigning allowAddonSideload;
firefox: support JACK and sndio audio backends You can set `media.cubeb.backend` in `about:config` to force a specific backend.
2022-05-07 18:31:10 -04:00
inherit jackSupport;
firefox: remove patchelf usage Firefox has a number of optional dependencies that get dlopened. Instead of using patchelf to set the RPATH use LD_LIBRARY_PATH. The motivation for this is we already set LD_LIBRARY_PATH in the wrapper on Linux.
2020-12-09 21:26:58 -05:00
inherit pipewireSupport;
firefox: support JACK and sndio audio backends You can set `media.cubeb.backend` in `about:config` to force a specific backend.
2022-05-07 18:31:10 -04:00
inherit sndioSupport;
firefox: refactor into firefoxPackages, add more options
2017-03-27 12:33:00 +00:00
inherit nspr;
inherit ffmpegSupport;
firefox: add Kerberos support
2017-09-27 13:30:29 +00:00
inherit gssSupport;
firefox: Add test references
2020-12-30 21:47:54 -05:00
inherit tests;
firefox: 89.0.2 -> 90.0 make gtk3Support non-optional, because it hasn't been for a long time also make gtk2 conditional on firefox older than 90, because we can get rid of it with firefox 90, but it's still needed by the current ESR release
2021-07-12 15:38:03 +02:00
inherit gtk3;
firefox: enable RLBox sandboxing https://hacks.mozilla.org/2021/12/webassembly-and-back-again-fine-grained-sandboxing-in-firefox-95/ Co-authored-by: Jörg Thalheim <joerg@thalheim.io>
2022-03-09 19:40:08 +01:00
inherit wasiSysRoot;
buildMozillaMach: allow distinct source and package versions Signed-off-by: Christoph Heiss <christoph@c8h4.io>
2023-10-10 17:35:11 +02:00
version = packageVersion;
librewolf: init at 97.0-2
2022-02-11 10:05:45 -08:00
} // extraPassthru;
firefox-esr-68: drop
2020-09-10 02:06:07 +02:00
firefox: 73.0.1 -> 74.0 (#82276) https://www.mozilla.org/en-US/firefox/74.0/releasenotes/ Co-authored-by: Daniel Frank <git@danielfrank.net>
2020-03-12 14:47:56 +01:00
hardeningDisable = [ "format" ]; # -Werror=format-security
firefox: simplify derivation with firefox 64 being the latest version, and the removal of "tor-browser/icecat-like" variants, we can greatly simplify the common firefox derivation.
2020-02-01 18:56:13 +01:00
firefox-esr-68: drop
2020-09-10 02:06:07 +02:00
# the build system verifies checksums of the bundled rust sources
# ./third_party/rust is be patched by our libtool fixup code in stdenv
# unfortunately we can't just set this to `false` when we do not want it.
# See https://github.com/NixOS/nixpkgs/issues/77289 for more details
firefox: fix build of >=72 on aarch64
2020-01-08 23:14:50 +01:00
# Ideally we would figure out how to tell the build system to not
# care about changed hashes as we are already doing that when we
# fetch the sources. Any further modifications of the source tree
# is on purpose by some of our tool (or by accident and a bug?).
firefox: prepare for firefox 72
2020-01-07 18:40:56 +01:00
dontFixLibtool = true;
firefox: fix build of >=72 on aarch64
2020-01-08 23:14:50 +01:00
# on aarch64 this is also required
dontUpdateAutotoolsGnuConfigScripts = true;
thunderbird, firefox, firefox-esr: set big-parallel Firefox and Thunder time out nearly everytime. Hopefully giving them more resources will prevent this from happening.
2020-11-29 10:28:24 +01:00
requiredSystemFeatures = [ "big-parallel" ];
buildMozillaMach: don't use lib.optional with a list
2023-06-22 19:04:37 -04:00
}
Reference in a new issue Copy permalink