movefasta/nixpkgs
1
0
Fork 0
mirror of https://github.com/NixOS/nixpkgs.git synced 2025-06-28 12:06:38 +03:00
Code Activity

buildkite-agent: 3.59.0 -> 3.76.1 (#331340)

Browse source 
* buildkite-agent: 3.59.0 -> 3.76.1

* nixos/buildkite-agent: put each agent in its own private /tmp

Workaround for https://github.com/buildkite/agent/issues/2916, but
probably still a good idea.
This commit is contained in:
Florian Klink 2024-08-02 22:59:32 +03:00 • committed by GitHub
parent 4197076f2b
commit 129558261d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 8 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
nixos/doc/manual/release-notes/rl-2411.section.md
View file

@ -321,6 +321,9 @@
- `nix.channel.enable = false` no longer implies `nix.settings.nix-path = []`. - `nix.channel.enable = false` no longer implies `nix.settings.nix-path = []`.
Since Nix 2.13, a `nix-path` set in `nix.conf` cannot be overriden by the `NIX_PATH` configuration variable. Since Nix 2.13, a `nix-path` set in `nix.conf` cannot be overriden by the `NIX_PATH` configuration variable.
- Buildkite Agents are now each running in their own private `/tmp`.
To return to the old behaviour, set `systemd.services.buildkite-agent-${name}.serviceConfig.PrivateTmp = false;`.
## Detailed migration information {#sec-release-24.11-migration} ## Detailed migration information {#sec-release-24.11-migration}
### `sound` options removal {#sec-release-24.11-migration-sound} ### `sound` options removal {#sec-release-24.11-migration-sound}

2
nixos/modules/services/continuous-integration/buildkite-agents.nix
View file

@ -205,6 +205,8 @@ in
serviceConfig = { serviceConfig = {
ExecStart = "${cfg.package}/bin/buildkite-agent start --config ${cfg.dataDir}/buildkite-agent.cfg"; ExecStart = "${cfg.package}/bin/buildkite-agent start --config ${cfg.dataDir}/buildkite-agent.cfg";
User = "buildkite-agent-${name}"; User = "buildkite-agent-${name}";
# Workaround https://github.com/buildkite/agent/issues/2916
PrivateTmp = lib.mkDefault true;
RestartSec = 5; RestartSec = 5;
Restart = "on-failure"; Restart = "on-failure";
TimeoutSec = 10; TimeoutSec = 10;

6
pkgs/by-name/bu/buildkite-agent/package.nix
View file

@ -13,16 +13,16 @@
}: }:
buildGoModule rec { buildGoModule rec {
pname = "buildkite-agent"; pname = "buildkite-agent";
version = "3.59.0"; version = "3.76.1";
src = fetchFromGitHub { src = fetchFromGitHub {
owner = "buildkite"; owner = "buildkite";
repo = "agent"; repo = "agent";
rev = "v${version}"; rev = "v${version}";
sha256 = "sha256-pYaxjXoNn6MOE2oHUSKrBzP5oKhtfJwSHFCkcpkyzas="; sha256 = "sha256-0i2b7sVBkV5zcJo+K5kg2Ojbix0rlQRXHKAmL9PJs+g=";
}; };
vendorHash = "sha256-JSuam9Tn+ZekfLrj78tBncH7Q2aP4CaUgaaDkJ/azEw="; vendorHash = "sha256-0P6EXqQa6WxhjNJ4X6THvjJRK/UQvqXTv+7IJViFAQs=";
postPatch = '' postPatch = ''
substituteInPlace clicommand/agent_start.go --replace /bin/bash ${bash}/bin/bash substituteInPlace clicommand/agent_start.go --replace /bin/bash ${bash}/bin/bash