movefasta/nixpkgs
0
0
Fork 0
mirror of https://github.com/NixOS/nixpkgs.git synced 2025-07-13 13:40:28 +03:00
Code Activity

python3Packages: provide setuptools-scm with toml[i] by default and remove duplicated toml packages

Browse source 
Some packages seem to still require toml despite setuptools-scm having switched to tomli.
If it is missing the version number in dist.into is set to 0.0.0 and silently all version pins break.
This commit is contained in:
Sandro Jäckel 2021-08-27 02:25:52 +02:00 • committed by Martin Weinelt
parent 684acec3e9
commit 2016ebd1fd
11 changed files with 20 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

6
pkgs/development/python-modules/setuptools-scm/default.nix
View file

@ -1,4 +1,4 @@
{ lib, buildPythonPackage, fetchPypi, toml }:
{ lib, buildPythonPackage, fetchPypi, toml, tomli }:
buildPythonPackage rec {
pname = "setuptools-scm";
@ -12,7 +12,9 @@ buildPythonPackage rec {
sha256 = "sha256-0ZJaacsH6bKUFqJ1ufrbAJojwUis6QWy+yIGSabBjpI=";
};
propagatedBuildInputs = [ toml ];
# TODO: figure out why both toml and tomli are needed when only tomli is listed in setuptools-scm
# if not both are listed some packages like zipp silently fallback to a 0.0.0 version number and break version pins in other packages
propagatedBuildInputs = [ toml tomli ];
# Requires pytest, circular dependency
doCheck = false;