From 4e690a28990f8dffd85d3dc68b8615014b4ef2d9 Mon Sep 17 00:00:00 2001 From: Grimmauld Date: Sat, 31 May 2025 18:08:09 +0200 Subject: [PATCH] udevCheckHook: remove broken cross-compilation check --- pkgs/by-name/ud/udevCheckHook/package.nix | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/pkgs/by-name/ud/udevCheckHook/package.nix b/pkgs/by-name/ud/udevCheckHook/package.nix index 261a503595ea..681b5d5f7a06 100644 --- a/pkgs/by-name/ud/udevCheckHook/package.nix +++ b/pkgs/by-name/ud/udevCheckHook/package.nix @@ -2,15 +2,16 @@ lib, makeSetupHook, systemdMinimal, - udev, stdenv, }: let # udev rules can only be checked if systemd (specifically, 'udevadm') can be executed on build platform - # if udev is not available on hostPlatform, there is no point in checking rules - applyHook = - lib.meta.availableOn stdenv.hostPlatform udev - && lib.meta.availableOn stdenv.buildPlatform systemdMinimal; + # If cross-compiling linux -> non-linux, udev rules are still checked, even if they end up being unused. + # This is not a problem: + # - If there are no udev rules, the hook is a noop + # - If the udev rules are broken, they should be flagged as such + # - if rules are not needed on a target platform where they are broken, they should be deleted from package output + applyHook = lib.meta.availableOn stdenv.buildPlatform systemdMinimal; in makeSetupHook { name = "udev-check-hook";