movefasta/nixpkgs
1
0
Fork 0
mirror of https://github.com/NixOS/nixpkgs.git synced 2025-06-10 11:45:45 +03:00
Code Issues Projects Releases Packages Wiki Activity

ci/eval: don't evaluate packages marked as broken

Browse source 
We really can't expect packages that are marked as broken to evaluate,
and *especially* not on unsupported platforms.

For context, we were attempting to eval them *past* the broken throw
previously, which caused fun side effects like [0].

When we set `includeBroken = true` before, this also included unfree
packages. Those would now be excluded, which is not what we want. Thus,
we explicitly enable them separately.

Commit by winterqt, message slightly reworded by wolfgangwalther.

[0]:
https://github.com/NixOS/nixpkgs/issues/355847#issuecomment-2878873137
This commit is contained in:
Winter 2025-05-13 00:02:38 -04:00 • committed by Wolfgang Walther
parent 3cc678fad5
commit 5240bdf3c6
No known key found for this signature in database
GPG key ID: B39893FA5F65CAE1
2 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
ci/eval/default.nix
View file

@ -73,7 +73,9 @@ let
# The number of attributes per chunk, see ./README.md for more info. # The number of attributes per chunk, see ./README.md for more info.
chunkSize, chunkSize,
checkMeta ? true, checkMeta ? true,
includeBroken ? true,
# Don't try to eval packages marked as broken.
includeBroken ? false,
# Whether to just evaluate a single chunk for quick testing # Whether to just evaluate a single chunk for quick testing
quickTest ? false, quickTest ? false,
}: }:

2
pkgs/top-level/release-outpaths.nix
View file

@ -27,7 +27,7 @@ let
config = { config = {
allowAliases = false; allowAliases = false;
allowBroken = includeBroken; allowBroken = includeBroken;
allowUnfree = false; allowUnfree = true;
allowInsecurePredicate = x: true; allowInsecurePredicate = x: true;
checkMeta = checkMeta; checkMeta = checkMeta;