From 1015c45b0e6082bd817e9c40342abdbd27b3df9c Mon Sep 17 00:00:00 2001 From: Emily Date: Sat, 24 May 2025 10:12:40 +0100 Subject: [PATCH] =?UTF-8?q?OWNERS:=20add=20more=20standard=20environment?= =?UTF-8?q?=E2=80=93related=20libraries?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I think it makes sense for the `stdenv` team to handle review of changes to these libraries that have substantial effects on the things in their scope, like the semantics of `stdenv.mkDerivation`, override interfaces, `meta` handling, and so on. This is already how `lib/systems/` is handled, and it makes sense to me to extend it. This would hopefully have helped avoid situations like and , where the `stdenv` team was unaware of the original change for weeks. --- ci/OWNERS | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/ci/OWNERS b/ci/OWNERS index 5466d0f2d8f0..c54edc80c4b5 100644 --- a/ci/OWNERS +++ b/ci/OWNERS @@ -28,13 +28,19 @@ # Libraries /lib @infinisil @hsjobeki -/lib/systems @alyssais @ericson2314 @NixOS/stdenv /lib/generators.nix @infinisil @hsjobeki @Profpatsch /lib/cli.nix @infinisil @hsjobeki @Profpatsch /lib/debug.nix @infinisil @hsjobeki @Profpatsch /lib/asserts.nix @infinisil @hsjobeki @Profpatsch /lib/path/* @infinisil @hsjobeki /lib/fileset @infinisil @hsjobeki +## Standard environment–related libraries +/lib/customisation.nix @alyssais @NixOS/stdenv +/lib/derivations.nix @alyssais @NixOS/stdenv +/lib/fetchers.nix @alyssais @NixOS/stdenv +/lib/meta.nix @alyssais @NixOS/stdenv +/lib/source-types.nix @alyssais @NixOS/stdenv +/lib/systems @alyssais @NixOS/stdenv ## Libraries / Module system /lib/modules.nix @infinisil @roberth @hsjobeki /lib/types.nix @infinisil @roberth @hsjobeki