From 82c6ea2ddc9a2d59c8c765f76bee8141d051f71c Mon Sep 17 00:00:00 2001 From: Wolfgang Walther Date: Mon, 2 Jun 2025 17:58:24 +0200 Subject: [PATCH] workflows/check-cherry-picks: minimize more than one old review After we removed the dismissed-review workflow, it can happen that multiple non-minimized reviews exist after a force push. To avoid cluttering the PR's history while it's actively worked on, we minimize all of them instead of only the latest. --- .github/workflows/check-cherry-picks.yml | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/.github/workflows/check-cherry-picks.yml b/.github/workflows/check-cherry-picks.yml index b7d914caffdc..77aafd9f0ff2 100644 --- a/.github/workflows/check-cherry-picks.yml +++ b/.github/workflows/check-cherry-picks.yml @@ -115,16 +115,17 @@ jobs: repo: context.repo.repo, pull_number: context.payload.pull_request.number })).filter(review => - review.user.login == 'github-actions[bot]' && - review.state == 'CHANGES_REQUESTED' + review.user.login == 'github-actions[bot]' ).map(async (review) => { - await github.rest.pulls.dismissReview({ - owner: context.repo.owner, - repo: context.repo.repo, - pull_number: context.payload.pull_request.number, - review_id: review.id, - message: 'All cherry-picks are good now, thank you!' - }) + if (review.state == 'CHANGES_REQUESTED') { + await github.rest.pulls.dismissReview({ + owner: context.repo.owner, + repo: context.repo.repo, + pull_number: context.payload.pull_request.number, + review_id: review.id, + message: 'All cherry-picks are good now, thank you!' + }) + } await github.graphql(`mutation($node_id:ID!) { minimizeComment(input: { classifier: RESOLVED,