movefasta/nixpkgs
1
0
Fork 0
mirror of https://github.com/NixOS/nixpkgs.git synced 2025-06-25 10:36:36 +03:00
Code Activity

nixos/scripted-networking: fix bridge setup when libvirtd uses socket activation

Browse source
This commit is contained in:
volth 2020-03-09 09:05:13 +00:00 • committed by wedens
parent d8664c78b1
commit 687aa06c70
1 changed files with 12 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

18
nixos/modules/tasks/network-interfaces-scripted.nix
View file

@ -291,13 +291,19 @@ let
${optionalString config.virtualisation.libvirtd.enable '' ${optionalString config.virtualisation.libvirtd.enable ''
# Enslave dynamically added interfaces which may be lost on nixos-rebuild # Enslave dynamically added interfaces which may be lost on nixos-rebuild
for uri in qemu:///system lxc:///; do #
for dom in $(${pkgs.libvirt}/bin/virsh -c $uri list --name); do # if `libvirtd.service` is not running, do not use `virsh` which would try activate it via 'libvirtd.socket' and thus start it out-of-order.
${pkgs.libvirt}/bin/virsh -c $uri dumpxml "$dom" | \ # `libvirtd.service` will set up bridge interfaces when it will start normally.
${pkgs.xmlstarlet}/bin/xmlstarlet sel -t -m "//domain/devices/interface[@type='bridge'][source/@bridge='${n}'][target/@dev]" -v "concat('ip link set ',target/@dev,' master ',source/@bridge,';')" | \ #
${pkgs.bash}/bin/bash if ${pkgs.systemd}/bin/systemctl --quiet is-active 'libvirtd.service'; then
for uri in qemu:///system lxc:///; do
for dom in $(${pkgs.libvirt}/bin/virsh -c $uri list --name); do
${pkgs.libvirt}/bin/virsh -c $uri dumpxml "$dom" | \
${pkgs.xmlstarlet}/bin/xmlstarlet sel -t -m "//domain/devices/interface[@type='bridge'][source/@bridge='${n}'][target/@dev]" -v "concat('ip link set ',target/@dev,' master ',source/@bridge,';')" | \
${pkgs.bash}/bin/bash
done
done done
done fi
''} ''}
# Enable stp on the interface # Enable stp on the interface