From 48d622fe551fb2a269a0260e35593b97432b31b6 Mon Sep 17 00:00:00 2001 From: Jan-Erik Rediger Date: Mon, 31 Jul 2023 12:18:03 +0200 Subject: [PATCH 1/2] git-cinnabar: 0.6.1 -> 0.6.2 --- .../version-management/git-cinnabar/default.nix | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkgs/applications/version-management/git-cinnabar/default.nix b/pkgs/applications/version-management/git-cinnabar/default.nix index 64fa89f436ab..92ba4bd81d1c 100644 --- a/pkgs/applications/version-management/git-cinnabar/default.nix +++ b/pkgs/applications/version-management/git-cinnabar/default.nix @@ -4,13 +4,13 @@ stdenv.mkDerivation rec { pname = "git-cinnabar"; - version = "0.6.1"; + version = "0.6.2"; src = fetchFromGitHub { owner = "glandium"; repo = "git-cinnabar"; rev = version; - sha256 = "VvfoMypiFT68YJuGpEyPCxGOjdbDoF6FXtzLWlw0uxY="; + sha256 = "1Y4zd4rYNRatemDXRMkQQwBJdkfOGfDWk9QBvJOgi7s="; fetchSubmodules = true; }; @@ -23,7 +23,7 @@ stdenv.mkDerivation rec { cargoDeps = rustPlatform.fetchCargoTarball { inherit src; - sha256 = "GApYgE7AezKmcGWNY+dF1Yp1TZmEeUdq3CsjvMvo/Rw="; + sha256 = "p85AS2DukUzEbW9UGYmiF3hpnZvPrZ2sRaeA9dU8j/8="; }; ZSTD_SYS_USE_PKG_CONFIG = true; From 57f4bdf484c4d5d64c3ea5576ebbc85dd635afc4 Mon Sep 17 00:00:00 2001 From: Pol Dellaiera Date: Mon, 31 Jul 2023 22:15:01 +0200 Subject: [PATCH 2/2] git-cinnabar: use `finalAttrs` pattern --- .../git-cinnabar/default.nix | 53 +++++++++++++------ 1 file changed, 37 insertions(+), 16 deletions(-) diff --git a/pkgs/applications/version-management/git-cinnabar/default.nix b/pkgs/applications/version-management/git-cinnabar/default.nix index 92ba4bd81d1c..ca6a0165f1d0 100644 --- a/pkgs/applications/version-management/git-cinnabar/default.nix +++ b/pkgs/applications/version-management/git-cinnabar/default.nix @@ -1,29 +1,48 @@ -{ stdenv, lib, fetchFromGitHub, cargo, pkg-config, rustPlatform -, bzip2, curl, zlib, zstd, libiconv, CoreServices +{ stdenv +, lib +, fetchFromGitHub +, cargo +, pkg-config +, rustPlatform +, bzip2 +, curl +, zlib +, zstd +, libiconv +, CoreServices }: -stdenv.mkDerivation rec { +stdenv.mkDerivation (finalAttrs: { pname = "git-cinnabar"; version = "0.6.2"; src = fetchFromGitHub { owner = "glandium"; repo = "git-cinnabar"; - rev = version; - sha256 = "1Y4zd4rYNRatemDXRMkQQwBJdkfOGfDWk9QBvJOgi7s="; + rev = finalAttrs.version; + hash = "sha256-1Y4zd4rYNRatemDXRMkQQwBJdkfOGfDWk9QBvJOgi7s="; fetchSubmodules = true; }; nativeBuildInputs = [ - pkg-config rustPlatform.cargoSetupHook cargo + cargo + pkg-config + rustPlatform.cargoSetupHook ]; - buildInputs = [ bzip2 curl zlib zstd ] - ++ lib.optionals stdenv.isDarwin [ libiconv CoreServices ]; + buildInputs = [ + bzip2 + curl + zlib + zstd + ] ++ lib.optionals stdenv.isDarwin [ + libiconv + CoreServices + ]; cargoDeps = rustPlatform.fetchCargoTarball { - inherit src; - sha256 = "p85AS2DukUzEbW9UGYmiF3hpnZvPrZ2sRaeA9dU8j/8="; + inherit (finalAttrs) src; + hash = "sha256-p85AS2DukUzEbW9UGYmiF3hpnZvPrZ2sRaeA9dU8j/8="; }; ZSTD_SYS_USE_PKG_CONFIG = true; @@ -32,17 +51,19 @@ stdenv.mkDerivation rec { installPhase = '' runHook preInstall + mkdir -p $out/bin install -v target/release/git-cinnabar $out/bin ln -sv git-cinnabar $out/bin/git-remote-hg + runHook postInstall ''; - meta = with lib; { - homepage = "https://github.com/glandium/git-cinnabar"; + meta = { description = "git remote helper to interact with mercurial repositories"; - license = licenses.gpl2Only; - maintainers = with maintainers; [ qyliss ]; - platforms = platforms.all; + homepage = "https://github.com/glandium/git-cinnabar"; + license = lib.licenses.gpl2Only; + maintainers = with lib.maintainers; [ qyliss ]; + platforms = lib.platforms.all; }; -} +})