movefasta/nixpkgs
0
0
Fork 0
mirror of https://github.com/NixOS/nixpkgs.git synced 2025-07-13 21:50:33 +03:00
Code Activity

livebook: fix service not starting when LIVEBOOK_COOKIE was not set

Browse source
This commit is contained in:
Alexandru Scvortov 2024-07-25 14:28:25 +01:00
parent f147a306d5
commit 742ee97845
2 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
nixos/modules/services/development/livebook.nix
View file

@ -89,6 +89,13 @@ in
EnvironmentFile = cfg.environmentFile; EnvironmentFile = cfg.environmentFile;
ExecStart = "${cfg.package}/bin/livebook start"; ExecStart = "${cfg.package}/bin/livebook start";
KillMode = "mixed"; KillMode = "mixed";
# Fix for the issue described here:
# https://github.com/livebook-dev/livebook/issues/2691
#
# Without this, the livebook service fails to start and gets
# stuck running a `cat /dev/urandom | tr | fold` pipeline.
IgnoreSIGPIPE = false;
}; };
environment = mapAttrs (name: value: environment = mapAttrs (name: value:
if isBool value then boolToString value else toString value) if isBool value then boolToString value else toString value)

5
nixos/tests/livebook-service.nix
View file

@ -11,9 +11,6 @@ import ./make-test-python.nix ({ lib, pkgs, ... }: {
enableUserService = true; enableUserService = true;
environment = { environment = {
LIVEBOOK_PORT = 20123; LIVEBOOK_PORT = 20123;
LIVEBOOK_COOKIE = "chocolate chip";
LIVEBOOK_TOKEN_ENABLED = true;
}; };
environmentFile = pkgs.writeText "livebook.env" '' environmentFile = pkgs.writeText "livebook.env" ''
LIVEBOOK_PASSWORD = "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx" LIVEBOOK_PASSWORD = "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
@ -38,7 +35,7 @@ import ./make-test-python.nix ({ lib, pkgs, ... }: {
machine.succeed("loginctl enable-linger alice") machine.succeed("loginctl enable-linger alice")
machine.wait_until_succeeds("${sudo} systemctl --user is-active livebook.service") machine.wait_until_succeeds("${sudo} systemctl --user is-active livebook.service")
machine.wait_for_open_port(20123) machine.wait_for_open_port(20123, timeout=10)
machine.succeed("curl -L localhost:20123 | grep 'Type password'") machine.succeed("curl -L localhost:20123 | grep 'Type password'")
''; '';