movefasta/nixpkgs
1
0
Fork 0
mirror of https://github.com/NixOS/nixpkgs.git synced 2025-06-13 05:05:29 +03:00
Code Issues Projects Releases Packages Wiki Activity

nixos/java: No bashisms in environment.shellInit script

Browse source 
Running dash (the lightweight Debian Almquist shell) results in

```
source: not found
```

For this line which ends up in `/etc/profile`. Let's use `.` instead, according to [the Ubuntu wiki](https://wiki.ubuntu.com/DashAsBinSh#source) and [`checkbashisms`](https://sourceforge.net/projects/checkbaskisms/):

```
possible bashism in /etc/profile line [...] (should be '.', not 'source'):
test -e /nix/store/[...]/nix-support/setup-hook && source /nix/store/[...]/nix-support/setup-hook
```
This commit is contained in:
Lorenz Leutgeb 2024-03-07 21:05:18 +01:00 • committed by GitHub
parent 8c8cf43fcd
commit 9692e2e819
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
nixos/modules/programs/java.nix
View file

@ -66,7 +66,7 @@ in
environment.systemPackages = [ cfg.package ];
environment.shellInit = ''
test -e ${cfg.package}/nix-support/setup-hook && source ${cfg.package}/nix-support/setup-hook
test -e ${cfg.package}/nix-support/setup-hook && . ${cfg.package}/nix-support/setup-hook
'';
};