diff --git a/nixos/doc/manual/from_md/release-notes/rl-2211.section.xml b/nixos/doc/manual/from_md/release-notes/rl-2211.section.xml
index c6eaf4624291..4e31668a9e8f 100644
--- a/nixos/doc/manual/from_md/release-notes/rl-2211.section.xml
+++ b/nixos/doc/manual/from_md/release-notes/rl-2211.section.xml
@@ -140,6 +140,12 @@
instead.
+
+
+ k3s no longer supports docker as runtime
+ due to upstream dropping support.
+
+
diff --git a/nixos/doc/manual/release-notes/rl-2211.section.md b/nixos/doc/manual/release-notes/rl-2211.section.md
index 56df3c00cb20..18bb0ee1cfc6 100644
--- a/nixos/doc/manual/release-notes/rl-2211.section.md
+++ b/nixos/doc/manual/release-notes/rl-2211.section.md
@@ -57,6 +57,8 @@ In addition to numerous new and upgraded packages, this release has the followin
- (Neo)Vim can not be configured with `configure.pathogen` anymore to reduce maintainance burden.
Use `configure.packages` instead.
+- `k3s` no longer supports docker as runtime due to upstream dropping support.
+
## Other Notable Changes {#sec-release-22.11-notable-changes}
diff --git a/nixos/modules/services/cluster/k3s/default.nix b/nixos/modules/services/cluster/k3s/default.nix
index 3a36cfa3f37b..421aa0aac60e 100644
--- a/nixos/modules/services/cluster/k3s/default.nix
+++ b/nixos/modules/services/cluster/k3s/default.nix
@@ -3,8 +3,14 @@
with lib;
let
cfg = config.services.k3s;
+ removeOption = config: instruction:
+ lib.mkRemovedOptionModule ([ "services" "k3s" ] ++ config) instruction;
in
{
+ imports = [
+ (removeOption [ "docker" ] "k3s docker option is no longer supported.")
+ ];
+
# interface
options.services.k3s = {
enable = mkEnableOption "k3s";
@@ -48,12 +54,6 @@ in
default = null;
};
- docker = mkOption {
- type = types.bool;
- default = false;
- description = "Use docker to run containers rather than the built-in containerd.";
- };
-
extraFlags = mkOption {
description = "Extra flags to pass to the k3s command.";
type = types.str;
@@ -88,14 +88,11 @@ in
}
];
- virtualisation.docker = mkIf cfg.docker {
- enable = mkDefault true;
- };
environment.systemPackages = [ config.services.k3s.package ];
systemd.services.k3s = {
description = "k3s service";
- after = [ "network.service" "firewall.service" ] ++ (optional cfg.docker "docker.service");
+ after = [ "network.service" "firewall.service" ];
wants = [ "network.service" "firewall.service" ];
wantedBy = [ "multi-user.target" ];
path = optional config.boot.zfs.enabled config.boot.zfs.package;
@@ -113,8 +110,8 @@ in
ExecStart = concatStringsSep " \\\n " (
[
"${cfg.package}/bin/k3s ${cfg.role}"
- ] ++ (optional cfg.docker "--docker")
- ++ (optional (cfg.docker && config.systemd.enableUnifiedCgroupHierarchy) "--kubelet-arg=cgroup-driver=systemd")
+ ]
+ ++ (optional (config.systemd.enableUnifiedCgroupHierarchy) "--kubelet-arg=cgroup-driver=systemd")
++ (optional cfg.disableAgent "--disable-agent")
++ (optional (cfg.serverAddr != "") "--server ${cfg.serverAddr}")
++ (optional (cfg.token != "") "--token ${cfg.token}")
diff --git a/nixos/tests/all-tests.nix b/nixos/tests/all-tests.nix
index d5e422bb94f2..099b8e7972c9 100644
--- a/nixos/tests/all-tests.nix
+++ b/nixos/tests/all-tests.nix
@@ -254,7 +254,6 @@ in {
jirafeau = handleTest ./jirafeau.nix {};
jitsi-meet = handleTest ./jitsi-meet.nix {};
k3s-single-node = handleTest ./k3s-single-node.nix {};
- k3s-single-node-docker = handleTest ./k3s-single-node-docker.nix {};
kafka = handleTest ./kafka.nix {};
kanidm = handleTest ./kanidm.nix {};
kbd-setfont-decompress = handleTest ./kbd-setfont-decompress.nix {};
diff --git a/nixos/tests/k3s-single-node-docker.nix b/nixos/tests/k3s-single-node-docker.nix
deleted file mode 100644
index 735aa5ac2975..000000000000
--- a/nixos/tests/k3s-single-node-docker.nix
+++ /dev/null
@@ -1,84 +0,0 @@
-import ./make-test-python.nix ({ pkgs, ... }:
-
- let
- imageEnv = pkgs.buildEnv {
- name = "k3s-pause-image-env";
- paths = with pkgs; [ tini (hiPrio coreutils) busybox ];
- };
- pauseImage = pkgs.dockerTools.streamLayeredImage {
- name = "test.local/pause";
- tag = "local";
- contents = imageEnv;
- config.Entrypoint = [ "/bin/tini" "--" "/bin/sleep" "inf" ];
- };
- # Don't use the default service account because there's a race where it may
- # not be created yet; make our own instead.
- testPodYaml = pkgs.writeText "test.yml" ''
- apiVersion: v1
- kind: ServiceAccount
- metadata:
- name: test
- ---
- apiVersion: v1
- kind: Pod
- metadata:
- name: test
- spec:
- serviceAccountName: test
- containers:
- - name: test
- image: test.local/pause:local
- imagePullPolicy: Never
- command: ["sh", "-c", "sleep inf"]
- '';
- in
- {
- name = "k3s";
- meta = with pkgs.lib.maintainers; {
- maintainers = [ euank ];
- };
-
- nodes.machine = { pkgs, ... }: {
- environment.systemPackages = with pkgs; [ k3s gzip ];
-
- # k3s uses enough resources the default vm fails.
- virtualisation.memorySize = 1536;
- virtualisation.diskSize = 4096;
-
- services.k3s = {
- enable = true;
- role = "server";
- docker = true;
- # Slightly reduce resource usage
- extraFlags = "--no-deploy coredns,servicelb,traefik,local-storage,metrics-server --pause-image test.local/pause:local";
- };
-
- users.users = {
- noprivs = {
- isNormalUser = true;
- description = "Can't access k3s by default";
- password = "*";
- };
- };
- };
-
- testScript = ''
- start_all()
-
- machine.wait_for_unit("k3s")
- machine.succeed("k3s kubectl cluster-info")
- machine.fail("sudo -u noprivs k3s kubectl cluster-info")
- # FIXME: this fails with the current nixos kernel config; once it passes, we should uncomment it
- # machine.succeed("k3s check-config")
-
- machine.succeed(
- "${pauseImage} | docker load"
- )
-
- machine.succeed("k3s kubectl apply -f ${testPodYaml}")
- machine.succeed("k3s kubectl wait --for 'condition=Ready' pod/test")
- machine.succeed("k3s kubectl delete -f ${testPodYaml}")
-
- machine.shutdown()
- '';
- })
diff --git a/pkgs/applications/networking/cluster/k3s/default.nix b/pkgs/applications/networking/cluster/k3s/default.nix
index 3cceae804cff..b1ad41b9d558 100644
--- a/pkgs/applications/networking/cluster/k3s/default.nix
+++ b/pkgs/applications/networking/cluster/k3s/default.nix
@@ -323,7 +323,7 @@ buildGoModule rec {
passthru.updateScript = ./update.sh;
- passthru.tests = { inherit (nixosTests) k3s-single-node k3s-single-node-docker; };
+ passthru.tests = { inherit (nixosTests) k3s-single-node; };
meta = baseMeta;
}