From c8920fc6d989807ccb3ba577c6a3e6d0b7258f17 Mon Sep 17 00:00:00 2001 From: Arthur Gautier Date: Wed, 12 Jul 2023 06:12:03 +0000 Subject: [PATCH 1/2] keepalived: fixup `virtualRouterId` documentation Router id 0 is an invalid option with keepalived --- .../services/networking/keepalived/vrrp-instance-options.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nixos/modules/services/networking/keepalived/vrrp-instance-options.nix b/nixos/modules/services/networking/keepalived/vrrp-instance-options.nix index 20e5558d7829..5d69963d2047 100644 --- a/nixos/modules/services/networking/keepalived/vrrp-instance-options.nix +++ b/nixos/modules/services/networking/keepalived/vrrp-instance-options.nix @@ -24,7 +24,7 @@ with lib; virtualRouterId = mkOption { type = types.int; description = lib.mdDoc '' - Arbitrary unique number 0..255. Used to differentiate multiple instances + Arbitrary unique number 1..255. Used to differentiate multiple instances of vrrpd running on the same NIC (and hence same socket). ''; }; From ee38adc8e2fa43ab2f8553cf47205ff750c81abf Mon Sep 17 00:00:00 2001 From: Arthur Gautier Date: Fri, 14 Jul 2023 20:52:48 +0000 Subject: [PATCH 2/2] keepalived: use `ints.between` Signed-off-by: Arthur Gautier --- .../services/networking/keepalived/vrrp-instance-options.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nixos/modules/services/networking/keepalived/vrrp-instance-options.nix b/nixos/modules/services/networking/keepalived/vrrp-instance-options.nix index 5d69963d2047..35401d439a91 100644 --- a/nixos/modules/services/networking/keepalived/vrrp-instance-options.nix +++ b/nixos/modules/services/networking/keepalived/vrrp-instance-options.nix @@ -22,7 +22,7 @@ with lib; }; virtualRouterId = mkOption { - type = types.int; + type = types.ints.between 1 255; description = lib.mdDoc '' Arbitrary unique number 1..255. Used to differentiate multiple instances of vrrpd running on the same NIC (and hence same socket).