From ee862a54b7ad53c1a0b797c4e01f9b933c228919 Mon Sep 17 00:00:00 2001 From: Sizhe Zhao Date: Fri, 6 Jun 2025 15:03:56 +0800 Subject: [PATCH 1/3] kaidan: move to by-name --- .../ka/kaidan/package.nix} | 50 +++++++------------ pkgs/top-level/all-packages.nix | 2 - 2 files changed, 19 insertions(+), 33 deletions(-) rename pkgs/{applications/networking/instant-messengers/kaidan/default.nix => by-name/ka/kaidan/package.nix} (71%) diff --git a/pkgs/applications/networking/instant-messengers/kaidan/default.nix b/pkgs/by-name/ka/kaidan/package.nix similarity index 71% rename from pkgs/applications/networking/instant-messengers/kaidan/default.nix rename to pkgs/by-name/ka/kaidan/package.nix index 319ab8a94626..7c911ff81376 100644 --- a/pkgs/applications/networking/instant-messengers/kaidan/default.nix +++ b/pkgs/by-name/ka/kaidan/package.nix @@ -5,22 +5,10 @@ cmake, extra-cmake-modules, pkg-config, - wrapQtAppsHook, - qtbase, - qttools, - qtmultimedia, - qtlocation, - qqc2-desktop-style, - kirigami-addons, - kirigami, - kio, - knotifications, - kquickimageedit, + kdePackages, zxing-cpp, qxmpp, - sonnet, gst_all_1, - prison, }: stdenv.mkDerivation rec { @@ -39,28 +27,28 @@ stdenv.mkDerivation rec { cmake extra-cmake-modules pkg-config - wrapQtAppsHook + kdePackages.wrapQtAppsHook ]; - buildInputs = with gst_all_1; [ - qtbase - qttools - qtmultimedia - qtlocation - qqc2-desktop-style - kirigami-addons - kirigami - kio - knotifications - kquickimageedit + buildInputs = [ + kdePackages.kio + kdePackages.kirigami + kdePackages.kirigami-addons + kdePackages.knotifications + kdePackages.kquickimageedit + kdePackages.prison + kdePackages.qtbase + kdePackages.qttools + kdePackages.qtmultimedia + kdePackages.qtlocation + kdePackages.qqc2-desktop-style + kdePackages.sonnet zxing-cpp qxmpp - sonnet - gstreamer - gst-plugins-bad - gst-plugins-base - (gst-plugins-good.override { qt6Support = true; }) - prison + gst_all_1.gstreamer + gst_all_1.gst-plugins-bad + gst_all_1.gst-plugins-base + (gst_all_1.gst-plugins-good.override { qt6Support = true; }) ]; postInstall = '' qtWrapperArgs+=(--prefix GST_PLUGIN_SYSTEM_PATH_1_0 : "$GST_PLUGIN_SYSTEM_PATH_1_0") diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 339dc8a399fe..f6a129323524 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -12979,8 +12979,6 @@ with pkgs; kbibtex = libsForQt5.callPackage ../applications/office/kbibtex { }; - kaidan = kdePackages.callPackage ../applications/networking/instant-messengers/kaidan { }; - kexi = libsForQt5.callPackage ../applications/office/kexi { }; kgraphviewer = callPackage ../applications/graphics/kgraphviewer { }; From 1001a577e6c7cfac57a8cbbb4268d1ad0f8a58d1 Mon Sep 17 00:00:00 2001 From: Sizhe Zhao Date: Fri, 6 Jun 2025 15:14:35 +0800 Subject: [PATCH 2/3] kaidan: use finalAttrs --- pkgs/by-name/ka/kaidan/package.nix | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkgs/by-name/ka/kaidan/package.nix b/pkgs/by-name/ka/kaidan/package.nix index 7c911ff81376..f974266a6e23 100644 --- a/pkgs/by-name/ka/kaidan/package.nix +++ b/pkgs/by-name/ka/kaidan/package.nix @@ -11,15 +11,15 @@ gst_all_1, }: -stdenv.mkDerivation rec { +stdenv.mkDerivation (finalAttrs: { pname = "kaidan"; version = "0.11.0"; src = fetchFromGitLab { domain = "invent.kde.org"; owner = "network"; - repo = pname; - rev = "v${version}"; + repo = "kaidan"; + rev = "v${finalAttrs.version}"; hash = "sha256-8pC4vINeKSYY+LlVgCXUtBq9UjraPdTikBOwLBLeQ3Y="; }; @@ -76,4 +76,4 @@ stdenv.mkDerivation rec { maintainers = with maintainers; [ astro ]; platforms = with platforms; linux; }; -} +}) From 209dc6172e041ffd434b08fc8d2be8c3eab00392 Mon Sep 17 00:00:00 2001 From: Sizhe Zhao Date: Fri, 6 Jun 2025 15:15:37 +0800 Subject: [PATCH 3/3] kaidan: avoid with lib; --- pkgs/by-name/ka/kaidan/package.nix | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkgs/by-name/ka/kaidan/package.nix b/pkgs/by-name/ka/kaidan/package.nix index f974266a6e23..825533dd245c 100644 --- a/pkgs/by-name/ka/kaidan/package.nix +++ b/pkgs/by-name/ka/kaidan/package.nix @@ -54,7 +54,7 @@ stdenv.mkDerivation (finalAttrs: { qtWrapperArgs+=(--prefix GST_PLUGIN_SYSTEM_PATH_1_0 : "$GST_PLUGIN_SYSTEM_PATH_1_0") ''; - meta = with lib; { + meta = { description = "User-friendly and modern chat app, using XMPP"; mainProgram = "kaidan"; longDescription = '' @@ -67,13 +67,13 @@ stdenv.mkDerivation (finalAttrs: { messages, and file sharing. ''; homepage = "https://www.kaidan.im"; - license = with licenses; [ + license = with lib.licenses; [ gpl3Plus mit asl20 cc-by-sa-40 ]; - maintainers = with maintainers; [ astro ]; - platforms = with platforms; linux; + maintainers = with lib.maintainers; [ astro ]; + platforms = with lib.platforms; linux; }; })