movefasta/nixpkgs
1
0
Fork 0
mirror of https://github.com/NixOS/nixpkgs.git synced 2025-06-10 03:23:29 +03:00
Code Issues Projects Releases Packages Wiki Activity

Revert "nixos/polkit: guard static gid for polkituser behind state version"

Browse source 
This reverts commit 2265160fc0 and
e56db577a1.

Ideally, we shouldn't cause friction for users that bump `stateVersion`,
and I'd consider having to switch and/or manually hardcode a UID/GID
to supress the warning friction. I think it'd be more beneficial to, in
this rare case of an ID being missed, just let it be until more
discussion happens surrounding this overall issue.

See https://github.com/NixOS/nixpkgs/pull/217785 for more context.
This commit is contained in:
Winter 2023-02-25 22:26:28 -05:00
parent 15f1369b95
commit ee6517a915
2 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
nixos/modules/misc/ids.nix
View file

@ -392,7 +392,7 @@ in
tape = 25; tape = 25;
video = 26; video = 26;
dialout = 27; dialout = 27;
polkituser = 28; #polkituser = 28; # currently unused, polkitd doesn't need a group
utmp = 29; utmp = 29;
# ddclient = 30; # converted to DynamicUser = true # ddclient = 30; # converted to DynamicUser = true
davfs2 = 31; davfs2 = 31;

4
nixos/modules/security/polkit.nix
View file

@ -113,9 +113,7 @@ in
group = "polkituser"; group = "polkituser";
}; };
users.groups.polkituser = { users.groups.polkituser = {};
gid = mkIf (lib.versionAtLeast config.system.stateVersion "23.05") config.ids.gids.polkituser;
};
}; };
} }