rippled{,-validator-keys-tool}: drop

This package was broken from May until November’s ZHF due to a Git
security change. In itself, that’s a one‐line fix, but a greater
concern is that this package hasn’t been updated since 2022; there
have been many releases since, including backward‐incompatible
protocol changes:

> If you operate an XRP Ledger server, upgrade to version 1.10.0 by
> March 21 to ensure service continuity.

Since it is after March 2023 and nobody has reported this package
broken, I conclude that nobody uses it, and we should remove it until
an interested maintainer comes along.
This commit is contained in:
Emily 2024-11-24 07:16:36 +00:00
parent 1635ae0b38
commit f1dd207da7
5 changed files with 2 additions and 230 deletions

View file

@ -1,23 +0,0 @@
{ lib, fetchFromGitHub, nodePackages }:
let
np = nodePackages.override { generated = ./package.nix; self = np; };
in nodePackages.buildNodePackage {
pname = "ripple-data-api";
version = "unstable-2015-03-26";
src = fetchFromGitHub {
owner = "ripple";
repo = "ripple-data-api";
rev = "c56b860105f36c1c44ae011189d495272648c589";
sha256 = "sha256-QEBdYdW55sAz6jshIAr2dSfXuqE/vqA2/kBeoxf75a8=";
};
deps = (lib.filter (v: lib.nixType v == "derivation") (lib.attrValues np));
meta = {
description = "Historical ripple data";
homepage = "https://github.com/ripple/ripple-data-api";
maintainers = with lib.maintainers; [ offline ];
};
}

View file

@ -1,165 +0,0 @@
{ lib, stdenv, fetchgit, fetchurl, fetchpatch, git, cmake, pkg-config
, openssl, boost, grpc, protobuf_21, libnsl, rocksdb_6_23, snappy }:
let
sqlite3 = fetchurl rec {
url = "https://www.sqlite.org/2018/sqlite-amalgamation-3260000.zip";
sha256 = "0vh9aa5dyvdwsyd8yp88ss300mv2c2m40z79z569lcxa6fqwlpfy";
passthru.url = url;
};
boostSharedStatic = boost.override {
enableShared = true;
enabledStatic = true;
};
docca = fetchgit {
url = "https://github.com/vinniefalco/docca.git";
rev = "335dbf9c3613e997ed56d540cc8c5ff2e28cab2d";
sha256 = "09cb90k0ygmnlpidybv6nzf6is51i80lnwlvad6ijc3gf1z6i1yh";
fetchSubmodules = false;
leaveDotGit = true;
};
nudb = fetchgit rec {
url = "https://github.com/CPPAlliance/NuDB.git";
rev = "2.0.5";
sha256 = "07dwvglhyzpqnhzd33a2vs80wrdxy55a3sirnd739xp1k5v8s2fx";
leaveDotGit = true;
fetchSubmodules = true;
postFetch = "cd $out && git tag ${rev}";
};
rocksdb = fetchgit {
url = "https://github.com/facebook/rocksdb.git";
rev = "v6.7.3";
sha256 = "0dzn5jg3i2mnnjj24dn9lzi3aajj5ga2akjf64lybyj481lq445k";
deepClone = true;
fetchSubmodules = false;
leaveDotGit = true;
};
lz4 = fetchgit rec {
url = "https://github.com/lz4/lz4.git";
rev = "v1.9.2";
sha256 = "0322xy2vfhxkb8akas7vwajjgcigq1q8l9f5fnfmavcsd6kmxmgg";
leaveDotGit = true;
fetchSubmodules = false;
postFetch = "cd $out && git tag ${rev}";
};
libarchive = fetchgit rec {
url = "https://github.com/libarchive/libarchive.git";
rev = "v3.4.3";
sha256 = "00yrzy2129vr4nfhigd91651984sl447dyfjfz26dmzvna5hwzp1";
leaveDotGit = true;
fetchSubmodules = false;
postFetch = "cd $out && git tag ${rev}";
};
soci = fetchgit {
url = "https://github.com/SOCI/soci.git";
rev = "04e1870294918d20761736743bb6136314c42dd5";
sha256 = "0w3b7qi3bwn8bxh4qbqy6c1fw2bbwh7pxvk8b3qb6h4qgsh6kx89";
leaveDotGit = true;
fetchSubmodules = false;
};
google-test = fetchgit {
url = "https://github.com/google/googletest.git";
rev = "5ec7f0c4a113e2f18ac2c6cc7df51ad6afc24081";
sha256 = "1ch7hq16z20ddhpc08slp9bny29j88x9vr6bi9r4yf5m77xbplja";
leaveDotGit = true;
fetchSubmodules = false;
};
google-benchmark = fetchgit {
url = "https://github.com/google/benchmark.git";
rev = "5b7683f49e1e9223cf9927b24f6fd3d6bd82e3f8";
sha256 = "0kcmb83framkncc50h0lyyz7v8nys6g19ja0h2p8x4sfafnnm6ig";
leaveDotGit = true;
fetchSubmodules = false;
};
date = fetchgit {
url = "https://github.com/HowardHinnant/date.git";
rev = "fc4cf092f9674f2670fb9177edcdee870399b829";
sha256 = "0w618p64mx2l074b6wd0xfc4h6312mabhvzabxxwsnzj4afpajcm";
leaveDotGit = true;
fetchSubmodules = false;
};
in stdenv.mkDerivation rec {
pname = "rippled";
version = "1.9.4";
src = fetchgit {
url = "https://github.com/ripple/rippled.git";
rev = version;
leaveDotGit = true;
fetchSubmodules = true;
hash = "sha256-VW/VmnhtF2xyHfEud3D6b3n8uTE0a/nDW1GISs5QfwM=";
};
patches = [
# Fix gcc-13 build due to missing <cstdint> includes:
# https://github.com/XRPLF/rippled/pull/4555
(fetchpatch {
name = "gcc-13.patch";
url = "https://github.com/XRPLF/rippled/commit/c9a586c2437bc8ffd22e946c82e1cbe906e1fc40.patch";
hash = "sha256-+4BDTMFoQWUHljgwGB1gtczVPQH/U5MA0ojbnBykceg=";
excludes = [ "src/ripple/basics/StringUtilities.h" ];
})
];
hardeningDisable = ["format"];
cmakeFlags = ["-Dstatic=OFF" "-DBoost_NO_BOOST_CMAKE=ON" "-DSNAPPY_INCLUDE_DIR=${snappy}/include" ];
nativeBuildInputs = [ pkg-config cmake git ];
buildInputs = [ openssl openssl.dev boostSharedStatic grpc protobuf_21 libnsl rocksdb_6_23 snappy ];
preConfigure = ''
export HOME=$PWD
git config --global --add safe.directory ${rocksdb}/.git
git config --global --add safe.directory ${docca}/.git
git config --global --add safe.directory ${lz4}/.git
git config --global --add safe.directory ${libarchive}/.git
git config --global --add safe.directory ${soci}/.git
git config --global --add safe.directory ${nudb}/.git
git config --global --add safe.directory ${google-benchmark}/.git
git config --global --add safe.directory ${google-test}/.git
git config --global --add safe.directory ${date}/.git
git config --global protocol.file.allow always
git config --global url."file://${rocksdb}".insteadOf "${rocksdb.url}"
git config --global url."file://${docca}".insteadOf "${docca.url}"
git config --global url."file://${lz4}".insteadOf "${lz4.url}"
git config --global url."file://${libarchive}".insteadOf "${libarchive.url}"
git config --global url."file://${soci}".insteadOf "${soci.url}"
git config --global url."file://${nudb}".insteadOf "${nudb.url}"
git config --global url."file://${google-benchmark}".insteadOf "${google-benchmark.url}"
git config --global url."file://${google-test}".insteadOf "${google-test.url}"
git config --global url."file://${date}".insteadOf "${date.url}"
substituteInPlace Builds/CMake/deps/Sqlite.cmake --replace "http://www.sqlite.org/2018/sqlite-amalgamation-3260000.zip" ""
substituteInPlace Builds/CMake/deps/Sqlite.cmake --replace "https://www2.sqlite.org/2018/sqlite-amalgamation-3260000.zip" ""
substituteInPlace Builds/CMake/deps/Sqlite.cmake --replace "http://www2.sqlite.org/2018/sqlite-amalgamation-3260000.zip" ""
substituteInPlace Builds/CMake/deps/Sqlite.cmake --replace "URL ${sqlite3.url}" "URL ${sqlite3}"
substituteInPlace Builds/CMake/deps/Rocksdb.cmake --replace "RocksDB 6.27" "RocksDB"
'';
doCheck = true;
checkPhase = ''
./rippled --unittest
'';
meta = with lib; {
description = "Ripple P2P payment network reference server";
homepage = "https://github.com/ripple/rippled";
maintainers = with maintainers; [ offline RaghavSood ];
license = licenses.isc;
platforms = platforms.linux;
mainProgram = "rippled";
};
}

View file

@ -1,36 +0,0 @@
{ stdenv, lib, fetchFromGitHub, cmake, openssl, boost, zlib, icu, rippled }:
stdenv.mkDerivation rec {
pname = "rippled-validator-keys-tool";
version = "0.3.2";
src = fetchFromGitHub {
owner = "ripple";
repo = "validator-keys-tool";
rev = "5d7efcfeda3bdf6f5dda78056004a7c326321e9b";
sha256 = "1irm8asp6plk9xw3ksf4fqnim8h0vj3h96w638lx71pga1h4zvmy";
};
nativeBuildInputs = [ cmake ];
buildInputs = [ openssl boost zlib icu rippled ];
hardeningDisable = ["format"];
cmakeFlags = [
"-Dep_procs=1"
];
installPhase = ''
runHook preInstall
install -D validator-keys $out/bin/validator-keys
runHook postInstall
'';
meta = with lib; {
description = "Generate master and ephemeral rippled validator keys";
homepage = "https://github.com/ripple/validator-keys-tool";
maintainers = with maintainers; [ offline rmcgibbo ];
license = licenses.isc;
platforms = [ "x86_64-linux" ];
};
}

View file

@ -1076,6 +1076,8 @@ mapAliases {
retroshare06 = retroshare;
rigsofrods = rigsofrods-bin; # Added 2023-03-22
ring-daemon = throw "'ring-daemon' has been renamed to/replaced by 'jami-daemon'"; # Converted to throw 2024-10-17
rippled = throw "rippled has been removed as it was broken and had not been updated since 2022"; # Added 2024-11-25
rippled-validator-keys-tool = throw "rippled-validator-keys-tool has been removed as it was broken and had not been updated since 2022"; # Added 2024-11-25
rockbox_utility = rockbox-utility; # Added 2022-03-17
rpiboot-unstable = throw "'rpiboot-unstable' has been renamed to/replaced by 'rpiboot'"; # Converted to throw 2024-10-17
rr-unstable = rr; # Added 2022-09-17

View file

@ -12190,12 +12190,6 @@ with pkgs;
protobuf = protobuf_21;
};
rippled = callPackage ../servers/rippled {
boost = boost177;
};
rippled-validator-keys-tool = callPackage ../servers/rippled/validator-keys-tool.nix { };
rustic = callPackage ../by-name/ru/rustic/package.nix {
inherit (darwin.apple_sdk.frameworks) Security SystemConfiguration;
};