By appling a patch from chaotic-nyx linking against icu76 and newer works
again.
From Firefox 139 upstream uses icu77, but it already works today on
138.0.1.
https://bugzilla.mozilla.org/show_bug.cgi?id=1927380
0:01.18 ERROR: SDK version "14.4" is too old. Please upgrade to at
least 15.2. Try updating your system Xcode. Newer versions of firefox
require apple-sdk_15.
Format all Nix files using the officially approved formatter,
making the CI check introduced in the previous commit succeed:
nix-build ci -A fmt.check
This is the next step of the of the [implementation](https://github.com/NixOS/nixfmt/issues/153)
of the accepted [RFC 166](https://github.com/NixOS/rfcs/pull/166).
This commit will lead to merge conflicts for a number of PRs,
up to an estimated ~1100 (~33%) among the PRs with activity in the past 2
months, but that should be lower than what it would be without the previous
[partial treewide format](https://github.com/NixOS/nixpkgs/pull/322537).
Merge conflicts caused by this commit can now automatically be resolved while rebasing using the
[auto-rebase script](8616af08d9/maintainers/scripts/auto-rebase).
If you run into any problems regarding any of this, please reach out to the
[formatting team](https://nixos.org/community/teams/formatting/) by
pinging @NixOS/nix-formatting.
It also aligns application names for wrapped and unwrapped flavors of
the same derivations; and uses unique application names for each flavor,
so it's now possible to install multiple versions on the same Darwin
machine.
One visible change now is that `About Firefox` window now shows:
`Firefox for NixOS` instead of `Mozilla Firefox for NixOS`
...in the `distribution` field. I think it's fine and doesn't infringe
on any trademarks because this field is not required to mention Mozilla at
all, as per: https://wiki.mozilla.org/Distribution_INI_File
While at it, also changed the branding for Darwin builds to list:
`Firefox for Nix on MacOS` instead of `Firefox for NixOS`
The telemetry and distribution ids (`nixos`) are left intact.
Note: it's still not possible to install both source-based and -bin
Darwin derivations in the same profile. It would require renaming
applicationNames for these two different types to use unique names (e.g.
`Firefox (Official)` or `Firefox (Binary)`, which doesn't seem optimal.
Closes: #378433Closes: #366581
Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
This branches off of the unmerged PR #294971, which had the goal of
distinguishing between the various Firefox packages by giving them all
unique binaryNames. The goal of this PR, by contrast, is making the
names of the XDG desktop files that we generate match the name by which
Firefox will identify itself over D-Bus.
Co-authored-by: Xandor Schiefer <me@xandor.co.za>
This fixes a regression in the discord web app. The issue was reported in:
https://github.com/NixOS/nixpkgs/issues/332540
The regression was introduced in commit 23d4f834 via an upgrade of rust
compiler from 1.77.2 to 1.78.0. The fix is based on a comparison between the
generated firefox build script generated by
pkgs/applications/networking/browsers/firefox/common.nix
and the firefox build script of archlinux found at:
1376cddc7e/PKGBUILD
Enabling "full" link time optimization fixed the regression in the discord web
app. Further compile flags where not ported from the archlinux build script.
Followup to https://github.com/NixOS/nixpkgs/pull/365185
Probably darwin does not have the elf-hack options, so restrict it to
platforms which have Elf.
Change-Id: I2d585721ca08df57a7d2d55bb5a727d34b3fb216
The elfhack was completely revamped and is now implemented with the
"relrhack", which is compatible with LLD:
https://glandium.org/blog/?p=4297
Exposes a new option elfhackSupport and sets reasonable default based on
the properties of the new relrhack.
Change-Id: I687d4ee68a8e836e5c51a1fde0d28d019c0c66b9
I have no idea why this is necessary for us and why the upstream patch
doesn’t work, but this gets the Mozilla packages building on LLVM
19 in the meantime while we try to figure that out.
Closes: #352724
In preparation for the deprecation of `stdenv.isX`.
These shorthands are not conducive to cross-compilation because they
hide the platforms.
Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way
One example of why this is bad and especially affects compiler packages
https://www.github.com/NixOS/nixpkgs/pull/343059
There are too many files to go through manually but a treewide should
get users thinking when they see a `hostPlatform.isX` in a place where it
doesn't make sense.
```
fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is"
fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is"
fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is"
```
The preliminary assumption is that this will land in 131 and then get
backported into the ESR releases. I don't plan to guess the correct
version boundaries at this time.
They're not autogenerated files any longer, and have been shipped as part
of the source tree since roughly Aug 2022.
Related: mozbz#1787977 ("Include configure in the tree")
Closes: #306937
This was achieved using the following command:
sd 'wrapGAppsHook\b' wrapGAppsHook3 (rg -l 'wrapGAppsHook\b')
And then manually reverted the following changes:
- alias in top-level.nix
- function name in wrap-gapps-hook.sh
- comment in postFixup of at-spi2-core
- comment in gtk4
- comment in preFixup of 1password-gui/linux.nix
- comment in postFixup of qgis/unwrapped-ltr.nix and qgis/unwrapped.nix
- comment in postFixup of telegram-desktop
- comment in postFixup of fwupd
- buildCommand of mongodb-compass
- postFixup of xflux-gui
- comment in a patch in kdePackages.kde-gtk-config and plasma5Packages.kde-gtk-config
- description of programs.sway.wrapperFeatures.gtk NixOS option (manual rebuild)
