mirror of
https://github.com/NixOS/nixpkgs.git
synced 2025-06-12 04:35:41 +03:00
e4bf5ce70d
lib/test.nix relies on `fileset.toSource` which creates a source dir
with the files of interest. `testers.shellcheck` passes all the files in
the source dir to shellcheck. The issue is related to relative path
sourcing, i.e. `source ./lib.sh` where shellcheck cannot make any
assumptions about the working directory.
Options were:
1) Disable this warning with a directive
Prior disabling in the tree:
- pkgs/tools/nix/info/info.sh
- nixos/modules/testing/test-instrumentation.nix
2) Set source-path to SCRIPTDIR with a directive
https://github.com/koalaman/shellcheck/wiki/Directive#source-path
Even though we don't enable external script following for shellcheck
with `-x` flag given every file in the source dir is passed, this
directive seems to capture the intent to help shellcheck a bit
better.
Went with option 2.
|
||
|---|---|---|
| .. | ||
| lib | ||
| activatable-system.nix | ||
| activation-script.nix | ||
| bootspec.cue | ||
| bootspec.nix | ||
| no-clone.nix | ||
| pre-switch-check.nix | ||
| specialisation.nix | ||
| switch-to-configuration.pl | ||
| switchable-system.nix | ||
| test.nix | ||
| top-level.nix | ||